Redirecting wiki page which ends with '/'

[Shunichi Goto <gotoh@…>]

If I request to wiki page url with slash at the end of url (i.e. .../wiki/StartPage/),
trac says "Describe "Start/" here" althou 'StartPage?' is exist.
To allow structured wiki pages, I think it is better that trac treat
".../wiki/StartPage/" page as ".../wiki/Startpage".

Here's a sample patch by using redirection:

web_ui.py

@@ -71 +71 @@
         action = req.args.get('action', 'view')
         pagename = req.args.get('page', 'WikiStart')
         version = req.args.get('version')
+        if 1 < len(pagename) and pagename.endswith('/'):
+            req.redirect(self.env.href.wiki(pagename[:-1]))
 
         db = self.env.get_db_cnx()

[Shunichi Goto <gotoh@…>]

s/structured/hierarchical/

[cboos]

I think it's a good idea.

However, it might be surprising, as it's an exception
to the normal rule for explicit wiki page links,
where the WikiPageNames syntax is ignored:
e.g. wiki:About/? would here link to the About wiki page,
instead of the expected "About/" page.

But as I think it would be troublesome to allow creating
a page with an ending "/", it's OK for me. Others?

[cboos]

#2323 marked as duplicate.

[cmlenz]

This is a good idea in my opinion. I'd drop the 1 < len(pagename) part from the condition, which isn't needed AFAICT.

[cboos]

Implemented in r2635.