Modify ↓
Ticket #2042 (closed defect: fixed)
Opened 6 years ago
Last modified 6 years ago
& characters in query: links are escaped twice
| Reported by: | mgood | Owned by: | cboos |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9 |
| Component: | general | Version: | 0.9b1 |
| Severity: | normal | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
The & characters in query: links (possibly others, but I haven't tested this yet) are escaped twice to: &
Attachments
Change History
comment:1 Changed 6 years ago by cboos
- Owner changed from mgood to cboos
- Status changed from new to assigned
- Version changed from 0.8.4 to 0.9b1
comment:2 Changed 6 years ago by cboos
Oops, sorry, just looked closer to ticket #1927
and learnt that
ampersands in URIs should be escaped...
I'll replace the patch soon.
Changed 6 years ago by cboos
- Attachment 2042-fix.patch added
Fixes query: and search: links. Takes into account #1927.
comment:3 Changed 6 years ago by cboos
- Priority changed from normal to high
That patch also fixes the query: links which start without "?".
Before, a Query.from_string was done on an already escaped string,
therefore the split on "&" produced an incorrect field name
(e.g. query:milestone=1.0&owner=me was transformed in amp;owner=me&milestone=1.0).
comment:4 Changed 6 years ago by cmlenz
cboos, I've tested this patch and it looks good. Can you please check it in?
comment:5 Changed 6 years ago by cboos
- Resolution set to fixed
- Status changed from assigned to closed
Patch applied in r2273.
Note: See
TracTickets for help on using
tickets.
I noticed that too while working on the search: links,
and I fixed it for the search, but not for the query: