& characters in query: links are escaped twice

[mgood]

The & characters in query: links (possibly others, but I haven't tested this yet) are escaped twice to: &

[cboos]

I noticed that too while working on the search: links, and I fixed it for the search, but not for the query:

• search:"?q=fix this&ticket=on"
• query:?order=priority&owner=me
• query:status=new|reopened

[cboos]

Oops, sorry, just looked closer to ticket #1927 and learnt that ampersands in URIs should be escaped...

I'll replace the patch soon.

[cboos]

Fixes query: and search: links. Takes into account #1927.

[cboos]

That patch also fixes the query: links which start without "?". Before, a Query.from_string was done on an already escaped string, therefore the split on "&" produced an incorrect field name (e.g. query:milestone=1.0&owner=me was transformed in amp;owner=me&milestone=1.0).

[cmlenz]

cboos, I've tested this patch and it looks good. Can you please check it in?

[cboos]

Patch applied in r2273.