Edgewall Software
Modify

Ticket #2014 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

Notification e-mails unreadable, unsendable.

Reported by: polarfox@… Owned by: eblot
Priority: high Milestone: 0.10
Component: ticket system Version: 0.9b1
Severity: major Keywords: notification email
Cc: nunterberg@…
Release Notes:
API Changes:

Description

When trying to send notification E-mail, half of them get rejected, and all are un-readable.

headers are so badly damaged that sendmail adds default mail domain after email, I'm suprised it got trough.

could someone help?

Attachments

bugmail.eml (1.5 KB) - added by polarfox@… 6 years ago.
fucked up e-mail source
Notify.py.patch (2.8 KB) - added by eblot 6 years ago.
First attempt to improve notification with MIME content
Notify.patch (3.9 KB) - added by eblot 6 years ago.
Other patch with better header encoding
ugly-notify.patch (1.1 KB) - added by polarfox@… 6 years ago.
add's some glue to eblot's patch that makes things work. ugly patch, but works for me.

Download all attachments as: .zip

Change History

Changed 6 years ago by polarfox@…

fucked up e-mail source

comment:1 Changed 6 years ago by polarfox@…

side note, this really prevents us from using trac to anything else than browsing subversion tree.

comment:2 Changed 6 years ago by polarfox@…

I don't understand python, so I wont go there, but looking at the mail, I think this is some serious overencoding and re-encoding shit :)
From: =?utf-8?q?Taajama_=3Cpolarfox=40taajama=2Efi=3E?=@smtp.taajama.com
'=40' there is '@', and so on, I think something is wrong way the mails are encoded.
Having done webmail software with php I've done many mistakes with encodings myself too, but this looks like easy to fix? maybe I should shut up and learn python.

comment:3 Changed 6 years ago by polarfox@…

After few hours hammering my head to the wall, I think I have a solution, DO NOT USE MIMEText :)

I found others saying that unicode in headers doesn't work like it should.
(http://www.zope.org/Wikis/DevSite/Projects/ComponentArchitecture/MailFormatting)

And really, those mail headers do blow up when using utf-8 to encode fields like: date, content-type, MIME-Version and email address parts of recipients and senders. there might be others but those are required for things to work ok.

comment:4 Changed 6 years ago by polarfox@…

I'm not sure, but these might work with postfix.
most e-mail clients do not parse headers that I listed that are encoded, but our webmail software does.
sendmail doesn't work right with encoded addresses either.
As you can see from my comments, this is really important to us, and I'm still on the case.

comment:5 Changed 6 years ago by anonymous

  • Priority changed from normal to high

comment:6 Changed 6 years ago by Norbert Unterberg <nunterberg@…>

  • Cc nunterberg@… added
  • Milestone set to 0.9

I've added milestone 0.9 so the ticket does not get lost ;-)

comment:7 Changed 6 years ago by cmlenz

  • Milestone changed from 0.9 to 0.9.1

Patches would be welcome for this issue ;-)

comment:8 Changed 6 years ago by eblot

  • Owner changed from jonas to anonymous
  • Status changed from new to assigned

comment:9 Changed 6 years ago by eblot

  • Owner changed from anonymous to eblot
  • Status changed from assigned to new

(I've started working on this one)

Changed 6 years ago by eblot

First attempt to improve notification with MIME content

comment:10 Changed 6 years ago by eblot

  • Owner changed from eblot to anonymous
  • Status changed from new to assigned

Mikko (polarfox@…), could you give a try with the patch I've attached to see whether it helps resolving this issue ?

The idea behind this patch is the following:

As we deal with MIME encoded data (utf-8/base64), a multipart MIME message is reated where only the mail body (text) and some headers are encoded, rather than creating a 'fully' encoded email, which seems to cause troubles with some kind of SMTP server.

Thanks. (patch built from [2391])

comment:11 Changed 6 years ago by mgood

  • Owner changed from anonymous to eblot
  • Status changed from assigned to new

comment:12 Changed 6 years ago by eblot

[2416] should address this issue. Can you give it a try ?

Changed 6 years ago by eblot

Other patch with better header encoding

comment:13 Changed 6 years ago by eblot

Polarfox, I've added another patch (based en [2391] as well). Could you also give it a try, if the [2416] changeset does not solve the header issue ?

Also try replacing "BASE64" with "QP" to check if the server has less trouble with quoted printable encoding.

comment:14 Changed 6 years ago by eblot

  • Keywords notification email added; notifications removed

Changed 6 years ago by polarfox@…

add's some glue to eblot's patch that makes things work. ugly patch, but works for me.

comment:15 Changed 6 years ago by cmlenz

  • Milestone changed from 0.9.1 to 0.9.2

comment:16 Changed 6 years ago by cmlenz

  • Milestone changed from 0.9.3 to 0.9.4

comment:17 Changed 6 years ago by eblot

  • Milestone changed from 0.9.4 to 0.10
  • Resolution set to fixed
  • Status changed from new to closed

Should be addressed by [2799]

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from eblot. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.