Edgewall Software
Modify

Opened 19 years ago

Closed 18 years ago

Last modified 17 years ago

#2014 closed defect (fixed)

Notification e-mails unreadable, unsendable.

Reported by: polarfox@… Owned by: Emmanuel Blot
Priority: high Milestone: 0.10
Component: ticket system Version: 0.9b1
Severity: major Keywords: notification email
Cc: nunterberg@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When trying to send notification E-mail, half of them get rejected, and all are un-readable.

headers are so badly damaged that sendmail adds default mail domain after email, I'm suprised it got trough.

could someone help?

Attachments (4)

bugmail.eml (1.5 KB ) - added by polarfox@… 19 years ago.
fucked up e-mail source
Notify.py.patch (2.8 KB ) - added by Emmanuel Blot 18 years ago.
First attempt to improve notification with MIME content
Notify.patch (3.9 KB ) - added by Emmanuel Blot 18 years ago.
Other patch with better header encoding
ugly-notify.patch (1.1 KB ) - added by polarfox@… 18 years ago.
add's some glue to eblot's patch that makes things work. ugly patch, but works for me.

Download all attachments as: .zip

Change History (21)

by polarfox@…, 19 years ago

Attachment: bugmail.eml added

fucked up e-mail source

comment:1 by polarfox@…, 19 years ago

side note, this really prevents us from using trac to anything else than browsing subversion tree.

comment:2 by polarfox@…, 19 years ago

I don't understand python, so I wont go there, but looking at the mail, I think this is some serious overencoding and re-encoding shit :) From: =?utf-8?q?Taajama_=3Cpolarfox=40taajama=2Efi=3E?=@smtp.taajama.com '=40' there is '@', and so on, I think something is wrong way the mails are encoded. Having done webmail software with php I've done many mistakes with encodings myself too, but this looks like easy to fix? maybe I should shut up and learn python.

comment:3 by polarfox@…, 19 years ago

After few hours hammering my head to the wall, I think I have a solution, DO NOT USE MIMEText :)

I found others saying that unicode in headers doesn't work like it should. (http://www.zope.org/Wikis/DevSite/Projects/ComponentArchitecture/MailFormatting)

And really, those mail headers do blow up when using utf-8 to encode fields like: date, content-type, MIME-Version and email address parts of recipients and senders. there might be others but those are required for things to work ok.

comment:4 by polarfox@…, 19 years ago

I'm not sure, but these might work with postfix. most e-mail clients do not parse headers that I listed that are encoded, but our webmail software does. sendmail doesn't work right with encoded addresses either. As you can see from my comments, this is really important to us, and I'm still on the case.

comment:5 by anonymous, 19 years ago

Priority: normalhigh

comment:6 by Norbert Unterberg <nunterberg@…>, 18 years ago

Cc: nunterberg@… added
Milestone: 0.9

I've added milestone 0.9 so the ticket does not get lost ;-)

comment:7 by Christopher Lenz, 18 years ago

Milestone: 0.90.9.1

Patches would be welcome for this issue ;-)

comment:8 by Emmanuel Blot, 18 years ago

Owner: changed from Jonas Borgström to anonymous
Status: newassigned

comment:9 by Emmanuel Blot, 18 years ago

Owner: changed from anonymous to Emmanuel Blot
Status: assignednew

(I've started working on this one)

by Emmanuel Blot, 18 years ago

Attachment: Notify.py.patch added

First attempt to improve notification with MIME content

comment:10 by Emmanuel Blot, 18 years ago

Owner: changed from Emmanuel Blot to anonymous
Status: newassigned

Mikko (polarfox@…), could you give a try with the patch I've attached to see whether it helps resolving this issue ?

The idea behind this patch is the following:

As we deal with MIME encoded data (utf-8/base64), a multipart MIME message is reated where only the mail body (text) and some headers are encoded, rather than creating a 'fully' encoded email, which seems to cause troubles with some kind of SMTP server.

Thanks. (patch built from [2391])

comment:11 by Matthew Good, 18 years ago

Owner: changed from anonymous to Emmanuel Blot
Status: assignednew

comment:12 by Emmanuel Blot, 18 years ago

[2416] should address this issue. Can you give it a try ?

by Emmanuel Blot, 18 years ago

Attachment: Notify.patch added

Other patch with better header encoding

comment:13 by Emmanuel Blot, 18 years ago

Polarfox, I've added another patch (based en [2391] as well). Could you also give it a try, if the [2416] changeset does not solve the header issue ?

Also try replacing "BASE64" with "QP" to check if the server has less trouble with quoted printable encoding.

comment:14 by Emmanuel Blot, 18 years ago

Keywords: notification email added; notifications removed

by polarfox@…, 18 years ago

Attachment: ugly-notify.patch added

add's some glue to eblot's patch that makes things work. ugly patch, but works for me.

comment:15 by Christopher Lenz, 18 years ago

Milestone: 0.9.10.9.2

comment:16 by Christopher Lenz, 18 years ago

Milestone: 0.9.30.9.4

comment:17 by Emmanuel Blot, 18 years ago

Milestone: 0.9.40.10
Resolution: fixed
Status: newclosed

Should be addressed by [2799]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Emmanuel Blot.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Emmanuel Blot to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.