Milestone Creation allows invalid characters

[thefigster@…]

I created a milestone named, "Bugs, etc." I can submit tickets to this milestone, it appears in the roadmap, however when I try to access it I get an error message stating that, "Milestone Bugs, etc does not exist." I think this is because the comma is creating an invalid url, however I am not positive. This may be something you want to look into.

[mgood]

These milestone naming issues seem to have been resolved for a while.

[mark.m.mcmahon@…]

This bug is still appearing on 0.10 (Windows based server, Apache 2.0.59, python 2.4.3).

Another invalid character is "/".

[cboos]

I'll take a look.

[gass@…]

Spaces in milestones are not a valid caracter either because they get impossible to make custom tycket queries.

[ThurnerRupert]

it happens with a milestone

asdf/ asd%ç+"*%

on 10.1-dev too.

[ThurnerRupert]

probably the only invalid character should be "/"? or it should behave the same way as wiki page names, where "/" is allowed even if i'm not sure what it denotes, a subpage, or a page which includes "/" in its name.

how do other wiki's solve this, like moinmoin, mediawiki?

[cboos]

Removing the special treatment on milestone names (i.e. removing the milestone.name.replace('/', '%2F') all over the places) fixed the issue for me, at least on trunk.

cmlenz, could you remind me why this was introduced, and whether you think this is still needed?

[cboos]

cmlenz told me this had to do with a weird problem in Apache...

I couldn't reproduce it, so I think it's best to cleanup the roadmap.py code and in the unlikely event that someone can reproduce the problem with Apache in the future, we'll address that issue at the appropriate level.

Fixed in r4196 (trunk) and r4198 (0.10-stable).

All of the following "weird" milestone names are now working for me:

• Teßt
• 0.10?
• The / Test
• milestone-0.9 & beyond ...
• (5) Build out front end functionality of sites
• back\slash

[chris.alex.thomas@…]

Hi,

I have just come across this problem, I am running trac 0.10.1 and I created a milestone called "Invoice / Financial area" and now when I click the milestone, it says exactly what is said above.

but this issue is closed, but how can that be if I am still having this problem with the latest code?

also, you cannot delete the item either, because it's name causes problems and using firefox webdeveloper to manually open the html, alter it and post that instead comes up with the same results, so now I am stuck with a milestone which is unusable.

output:
"Internal Error

Milestone Invoice %2F Financial Area does not exist."

url: ​http://<trac-url>/milestone/Invoice%20%252F%20Financial%20Area

this bug isnt dead yet.

[Tim Hatch <trac@…>]

This bug was present in 0.10.1 and fixed for 0.10.2. See TracDownload for how to download a new version if your package maintainer hasn't already. If the slashes cause you an issue once running 0.10.2, by all means please reopen.

[anonymous]

I am still experiencing this bug in trac 0.10.4
I have a milestone named: test/test
When I create it, I immediately get an error:

Internal Error

Milestone test%2Ftest does not exist.

The milestone still appears in my Roadmap list though. When I click it, I get the same error.

[cboos]

Replying to anonymous:

I am still experiencing this bug in trac 0.10.4

Sorry, it definitely works for me using milestone:0.10.4, when creating a new milestone from the roadmap page. Did you perhaps attempt to create the milestone with the WebAdmin (and an old version of it?)

Double check your installation against the pristine 0.10.4 code, I'm quite sure it's an installation issue.

[cmlenz]

Is this using mod_python?

[anonymous]

Replying to cboos:

Replying to anonymous:

I am still experiencing this bug in trac 0.10.4

Sorry, it definitely works for me using milestone:0.10.4, when creating a new milestone from the roadmap page. Did you perhaps attempt to create the milestone with the WebAdmin (and an old version of it?)

Double check your installation against the pristine 0.10.4 code, I'm quite sure it's an installation issue.

I have created the new milestone from the roadmap page (using FireFox?) and I definitely upgraded to 0.10.4. It might be an installation issue but I don't know how to check for that. I used the windows installer for 0.10.4 to upgrade.
I am using mod_python by the way.

[anonymous]

Ok now it works. I forgot to run TRAC_Admin upgrade... my bad. My apologies.

[cboos]

Well, I don't think that trac-admin upgrade did play a role here... Probably you were still using some older Trac release, and once you were really using 0.10.4 (after a restart of apache?), things worked.

[jenchitty@…]

There seems to be a related issue here with Trac 0.11.7, where a change to the list of Milestones takes a looong time to propagate through the database or get into some caches, or something.

1. I create a new Milestone called "1.7.X".
2. I try to re-target a ticket to that Milestone (it shows up in the drop down in the Ticket form), but I get the following warning when I try to submit my changes:

   Warning:  "1.7.X" is not a valid value for the milestone field.
   

3. I check that the 1.7.X milestone exists in the roadmap, and it is there. I can even update the description.
4. I refresh my ticket window and the "1.7.X" entry disappears from the drop-down!
5. I refresh my ticket window again and the "1.7.X" entry re-appears!
6. I try to re-target again, and it fails with the same warning again.
7. I wait 15 minutes and click the "Submit changes" button on the ticket again, and it succeeds.

[cboos]

Hm, I wonder if we didn't do a config.touch() in this case?

Anyway, it's a bit too late now for 0.11.x, as this release line will only get security fixes (if any).

This scenario is already much better handled on 0.12.x anyway, so it's time to upgrade ;-)