Edgewall Software
Modify

Ticket #1562 (closed defect: fixed)

Opened 5 years ago

Last modified 22 months ago

Link problem for reports with dynamic variables

Reported by: t.dettrick@… Owned by: daniel
Priority: normal Milestone: 0.9
Component: report system Version: 0.9b2
Severity: major Keywords:
Cc: trac-form@…

Description

Links given as:

[report:123?MYVAR=myvalue My Report]

result in all of the links on the generated report consisting of things like:

http://...../report/123?MYVAR=myvalue/ticket/345

As of Revision 1677.

Attachments

report-fix.diff (786 bytes) - added by trac-form@… 5 years ago.
Dubious fix for this bug.

Change History

comment:1 Changed 5 years ago by t.dettrick@…

It appears to do this because the link:

[report:123?MYVAR=myvalue My Report]

generates the href:

...../report/11%3FMYVAR%3Dmyvalue

instead of:

...../report/11?MYVAR=myvalue

This confuses Apache into believing that the OS environment variable SCRIPT_NAME is the same as REQUEST_URI, rather than being the URL of the Trac project. Obviously the solution is to stop the GET request parameters being encoded.

comment:2 Changed 5 years ago by anonymous

  • Version changed from devel to 0.9b2
  • Milestone set to 0.9

comment:3 Changed 5 years ago by anonymous

This worked in 0.8.x

Changed 5 years ago by trac-form@…

Dubious fix for this bug.

comment:4 Changed 5 years ago by trac-form@…

I'm not sure whether this patch is correctly implemented, but it works: eg.  http://trac-hacks.swapoff.org/wiki/TocMacro

comment:5 Changed 5 years ago by anonymous

  • Cc trac-form@… added

comment:6 Changed 5 years ago by cmlenz

  • Status changed from new to closed
  • Resolution set to fixed

Applied patch in [2322]. Well, except for the part that removed the report shorthand syntax ;-)

comment:7 Changed 22 months ago by www.ticketpoint.de

There are new patches? I badly need a patch! Plz let me know. Thx

comment:8 Changed 22 months ago by ebray

Hmm...does BadContent also apply to usernames?

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from daniel. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.