Edgewall Software
Modify

Ticket #1544 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

change/restore ticket field leads to adding fake ticket change

Reported by: pkou at ua.fm Owned by: cmlenz
Priority: normal Milestone: 0.9
Component: ticket system Version: 0.8
Severity: trivial Keywords:
Cc:
Release Notes:
API Changes:

Description

When ticket field is changed, then original value is saved for tracking ticket changes. However, if a field is changed to some value and then to original value, then this change is tracked.

Patch for trunk:

Index: Ticket.py
===================================================================
--- Ticket.py   (revision 1667)
+++ Ticket.py   (working copy)
@@ -53,6 +53,8 @@
             return
         if not self._old.has_key(name):
             self._old[name] = self.get(name, None)
+        else if self._old[name] == value:
+            del self._old[name]
         dict.__setitem__(self, name, value)

     def _forget_changes(self):

(In preparation to #869)

Attachments

Change History

comment:1 Changed 7 years ago by cmlenz

  • Owner changed from jonas to cmlenz
  • Status changed from new to assigned

comment:2 Changed 7 years ago by cmlenz

Heh, else if doesn't really work in python ;-)

comment:3 Changed 7 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [1668].

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cmlenz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.