Edgewall Software
Modify

Ticket #1365 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

[patch] repo browser ignores authz

Reported by: Matthew Good <trac matt-good net> Owned by: jonas
Priority: normal Milestone: 0.9
Component: version control/browser Version: devel
Severity: major Keywords:
Cc:
Release Notes:
API Changes:

Description

The browser doesn't pass in the username for the authorization so it gets ignored.

=== trac/Browser.py
==================================================================
--- trac/Browser.py  (revision 1841)
+++ trac/Browser.py  (local)
@@ -72,7 +72,7 @@
         if len(path_links) > 1:
             add_link(req, 'up', path_links[-2]['href'], 'Parent directory')

-        repos = self.env.get_repository()
+        repos = self.env.get_repository(req.authname)
         req.hdf['browser.revision'] = rev or repos.youngest_rev

         node = repos.get_node(path, rev)
@@ -218,7 +218,7 @@
         if path_links:
             add_link(req, 'up', path_links[-1]['href'], 'Parent directory')

-        repos = self.env.get_repository()
+        repos = self.env.get_repository(req.authname)
         node = repos.get_node(path, rev)
         if not node:
             # FIXME: we should send a 404 error here

Attachments

Change History

comment:1 Changed 7 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from new to closed

Patch applied in [1449]. Thanks!

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.