Display of changeset page in source browser is fixed in GECKO-based browsers, still disturbed in Opera and Konqueror

[peter.fischer@…]

Thank you for fixing #1087 a.k.a #1129. While testing if 8.1 will work for me (and my fellow colleagues) I found these:

Changesetpage_in_FireFox1.0.jpg (okay, for comparison) Changesetpage_in_Konqueror3.3.jpg (table for diff display broken) Changesetpage_in_Opera7.54.jpg (Author/Messages/Files and colour legend wrong placed) Changesetpage_in_Opera8beta.jpg (Author/Messages/Files wrong placed)

Tested with browsers mentioned in screenshot title on linux and W2k-SP4 (except Konqueror on W2k and IE on linux ;) ).

IE on W2k displays ok, except for the font size of the Home/Download/Documentation/... menu on the left, but who does use IE anyway?

[cmlenz]

See #1246 for more on the Konqueror problem.

[nil4]

The following diff.css snippet displays changesets perfectly in Opera 8.0b3, Firefox 1.0.1 and IE 6.0. The only catch is that this only works as long as the <dd> tags are not empty (need a nbsp instead of the empty value).

#overview dt {
 font-weight: bold;
 padding-right: .25em;
/* position: absolute;
 left: 0;*/
 text-align: right;
 width: 7.75em;
 float: left;
}
#overview dd { margin-left: 8.2em }

Sorry for not posting a diff, I'm not familiar with that. Hope it helps.

[mgood]

Combining the above style with some  CSS hacks preserves the layout when the <dd>s are empty:

htdocs/css/diff.css

@@ -10 +10 @@
 #overview dt {
  font-weight: bold;
  padding-right: .25em;
- position: absolute;
- left: 0;
+ float: left;
  text-align: right;
  width: 7.75em;
 }
-#overview dd { margin-left: 8em }
+#overview dd { margin-left: 8.2em }
+/* Fix for empty DDs */
+#overview dd:after {
+ content: ".";
+ display: block;
+ height: 0;
+ clear: left;
+ visibility: hidden;
+}
+/* Hide from IE-mac \*/
+* html .clearfix { height: 1%; }
+/* End fix for empty DDs */
 
 /* Colors for change types */
 #chglist .edit, #overview .mod, .diff #legend .mod { background: #fd8 }

I'll leave this open for alternatives since this hack is a bit ugly.

[fate]

As far as I can tell the code change to diff.css below displays the changeset properly in Opera 8.02, IE 6 and Firefox 1.5. It works even when the dd tags are empty.

#overview dt {
 font-weight: bold;
 padding-right: .25em;
 /*position: absolute;*/
 left: 0;
 float:left;
 clear:left;
 text-align: right;
 width: 7.75em;
}

[jonas]

#2715 has been marked as a duplicate of this ticket.

[cmlenz]

Sorry, still not going to make it into 0.9.4... postponing again.

[cboos]

Removing the position: absolute seems to break the layout for IExplorer and Firefox (fate, did you forget to force reload after the CSS change?)

Opera 9beta preview 2 still has the bug, but I noticed that using its Print preview mode (Shift-P), the <dt> are correctly rendered.

So I'd propose to postpone this a bit more, as I don't see that as a blocker for 0.10.

[cboos]

(didn't meant to assign it to me)

[cboos]

Opera 9 (win32, Build 8502) seems to be doing fine on Changesets now!

[cboos]

Seems to work well for all major browsers now.