Ticket #1288 (closed defect: worksforme)
Opened 7 years ago
Last modified 5 years ago
Display of changeset page in source browser is fixed in GECKO-based browsers, still disturbed in Opera and Konqueror
| Reported by: | peter.fischer@… | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | version control/changeset view | Version: | devel |
| Severity: | normal | Keywords: | layout patch |
| Cc: | peter.fischer@… | ||
| Release Notes: | |||
| API Changes: | |||
Description
Thank you for fixing #1087 a.k.a #1129.
While testing if 8.1 will work for me (and my fellow colleagues) I found these:
Changesetpage_in_FireFox1.0.jpg (okay, for comparison)
Changesetpage_in_Konqueror3.3.jpg (table for diff display broken)
Changesetpage_in_Opera7.54.jpg (Author/Messages/Files? and colour legend wrong placed)
Changesetpage_in_Opera8beta.jpg (Author/Messages/Files? wrong placed)
Tested with browsers mentioned in screenshot title on linux and W2k-SP4 (except Konqueror on W2k and IE on linux ;) ).
IE on W2k displays ok, except for the font size of the Home/Download/Documentation/?... menu on the left, but who does use IE anyway?
Attachments
Change History
Changed 7 years ago by peter.fischer@…
- Attachment Changesetpage_in_FireFox1.0.jpg added
Changed 7 years ago by peter.fischer@…
- Attachment Changesetpage_in_Konqueror3.3.jpg added
Changed 7 years ago by peter.fischer@…
- Attachment Changesetpage_in_Opera7.54.jpg added
Changed 7 years ago by peter.fischer@…
- Attachment Changesetpage_in_Opera8beta.jpg added
comment:1 Changed 7 years ago by cmlenz
- Component changed from browser to changeset view
- Keywords layout added
comment:2 Changed 7 years ago by cmlenz
- Owner changed from jonas to cmlenz
comment:3 Changed 7 years ago by nil4
- Version changed from 0.8.1 to devel
The following diff.css snippet displays changesets perfectly in Opera 8.0b3, Firefox 1.0.1 and IE 6.0. The only catch is that this only works as long as the <dd> tags are not empty (need a nbsp instead of the empty value).
#overview dt { font-weight: bold; padding-right: .25em; /* position: absolute; left: 0;*/ text-align: right; width: 7.75em; float: left; } #overview dd { margin-left: 8.2em }
Sorry for not posting a diff, I'm not familiar with that. Hope it helps.
comment:4 Changed 6 years ago by cmlenz
- Milestone set to 0.9.1
- Status changed from new to assigned
comment:5 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.1 to 0.9.2
comment:6 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.3 to 0.9.4
comment:7 Changed 6 years ago by mgood
- Keywords patch added
Combining the above style with some CSS hacks preserves the layout when the <dd>s are empty:
-
htdocs/css/diff.css
==================================================================
10 10 #overview dt { 11 11 font-weight: bold; 12 12 padding-right: .25em; 13 position: absolute; 14 left: 0; 13 float: left; 15 14 text-align: right; 16 15 width: 7.75em; 17 16 } 18 #overview dd { margin-left: 8em } 17 #overview dd { margin-left: 8.2em } 18 /* Fix for empty DDs */ 19 #overview dd:after { 20 content: "."; 21 display: block; 22 height: 0; 23 clear: left; 24 visibility: hidden; 25 } 26 /* Hide from IE-mac \*/ 27 * html .clearfix { height: 1%; } 28 /* End fix for empty DDs */ 19 29 20 30 /* Colors for change types */ 21 31 #chglist .edit, #overview .mod, .diff #legend .mod { background: #fd8 }
I'll leave this open for alternatives since this hack is a bit ugly.
comment:8 Changed 6 years ago by fate
As far as I can tell the code change to diff.css below displays the changeset properly in Opera 8.02, IE 6 and Firefox 1.5. It works even when the dd tags are empty.
#overview dt { font-weight: bold; padding-right: .25em; /*position: absolute;*/ left: 0; float:left; clear:left; text-align: right; width: 7.75em; }
comment:9 Changed 6 years ago by jonas
#2715 has been marked as a duplicate of this ticket.
comment:10 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.4 to 0.9.5
Sorry, still not going to make it into 0.9.4... postponing again.
comment:11 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.5 to 0.10
comment:12 Changed 6 years ago by cboos
- Milestone changed from 0.10 to 0.11
- Owner changed from cmlenz to cboos
- Status changed from assigned to new
Removing the position: absolute seems to break the layout for IExplorer and Firefox (fate, did you forget
to force reload after the CSS change?)
Opera 9beta preview 2 still has the bug,
but I noticed that using its Print preview mode
(Shift-P), the <dt> are correctly rendered.
So I'd propose to postpone this a bit more, as I don't see that as a blocker for 0.10.
comment:13 Changed 6 years ago by cboos
- Owner changed from cboos to cmlenz
(didn't meant to assign it to me)
comment:14 Changed 6 years ago by cboos
Opera 9 (win32, Build 8502) seems to be doing fine on Changesets now!
comment:15 Changed 5 years ago by cboos
- Milestone 0.11 deleted
- Resolution set to worksforme
- Status changed from new to closed
Seems to work well for all major browsers now.



See #1246 for more on the Konqueror problem.