Edgewall Software
Modify

Ticket #1278 (new defect)

Opened 7 years ago

Last modified 17 months ago

attaching file to wiki page does not register as changed page

Reported by: Phil Mocek <pmocek-edgewall-tracwiki@…> Owned by: cboos
Priority: lowest Milestone: next-major-0.1X
Component: attachment Version: 0.8.1
Severity: normal Keywords: wiki attach history changes
Cc: martin@…
Release Notes:
API Changes:

Description

When a file is attached to a wiki page, the page does not show a change in its page history and the page does not show up on the list of RecentChanges or timeline.

For example, I attached a file to SandBox/SubPage? on 2005-03-10, but that page's history indicates that it was last modified on 2004-11-16.

Attachments

Change History

comment:1 Changed 6 years ago by cboos

  • Milestone set to 0.10
  • Owner changed from jonas to cboos

#1498 was marked as duplicate of this one.
See also #2259 which is about nearly the same issue,
but for tickets.

comment:2 Changed 6 years ago by cboos

  • Milestone changed from 0.10 to 0.11

This ticket will require some general changes on the way
the attachment changes interfere with the main resource
changes, and I think it's too late to do that in 0.10 now.

Post-poning.

comment:3 Changed 5 years ago by sid

#2725 is similar (Ticket changetime is not updated with an attachment) and has a patch.

comment:4 Changed 5 years ago by cboos

  • Milestone changed from 0.11 to 0.12

I closed #2725 as a duplicate of this one, as the data model changes will affect the attachments for any resources (wiki pages, tickets, and by then, the milestone and probably a few others...).

comment:5 Changed 4 years ago by osimons

Should the attachment module really have such consequences for its 'parent' on the model level? With the current (0.11b1+) status of disconnected resources and loosly-coupled code, I suppose it is up the parent resource to decide if it wants to register the change in any way.

So, if the Wiki wants to save a new version of itself to mark the event, can't it just implement the IAttachmentChangeListener and log a new version with a comment that attachment 'somefile.txt' is added or deleted?

That should then of course trigger a call to IWikiChangeListener, show the new version in timeline and so on...

comment:6 Changed 4 years ago by Piotr Kuczynski <piotr.kuczynski@…>

  • Component changed from wiki system to attachment

comment:7 Changed 22 months ago by anonymous

I'm using Trac 0.11.7. Any idea to fix the issue "ticket changetime is not updated with an attachment" on this version?

I have tried the patch attached on ticket #2725. But it have following error,
AttributeError?: 'Attachment' object has no attribute 'parent_type'

comment:8 Changed 20 months ago by rblank

  • Milestone changed from next-major-0.1X to unscheduled

comment:9 Changed 20 months ago by cboos

  • Milestone changed from unscheduled to next-major-0.1X
  • Priority changed from normal to lowest

Keeping on the long term plan (comment:4).

comment:10 Changed 17 months ago by Martin Scharrer <martin@…>

  • Cc martin@… added
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as new
as The resolution will be set. Next status will be 'closed'
to The owner will be changed from cboos. Next status will be 'new'
The owner will be changed from cboos to anonymous. Next status will be 'assigned'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.