Edgewall Software

Changes between Initial Version and Version 1 of Ticket #12639, comment 56


Ignore:
Timestamp:
Sep 12, 2019, 4:51:43 AM (5 years ago)
Author:
Jun Omae

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12639, comment 56

    initial v1  
    22> Follow-up to r15445: I'm thinking we should log at error level: [browser:branches/1.4-stable/trac/ticket/notification.py@17177:320#L311].
    33
    4 `EmailDistributor` catches exceptions and logs as a warngin while executing `INotificationFormatter.format()` at [source:/tags/trac-1.4/trac/notification/mail.py@:384-390#L377]. I consider it is not needed to catch exceptions in `format()` method of `INotificationFormatter` components.
     4`EmailDistributor` catches exceptions and logs as a warning while executing `INotificationFormatter.format()` at [source:/tags/trac-1.4/trac/notification/mail.py@:384-390#L377]. I consider it is not needed to catch exceptions in `format()` method of `INotificationFormatter` components.