Possible mistyped processor on TracDownload

[figaro]

At the bottom of page TracDownload the following is shown: Error: Failed to load processor apache No macro or processor named 'apache' found

This is possibly the result of a mistyped processor on that page.

[figaro]

Updated description and summary.

[Ryan J Ollos]

This is due to a Pygments installation issue that I've noted in our internal issue tracker. However, the issue is also present on TracModWSGI which gets distributed with Trac so the errors will be seen whenever Pygments is not installed. We should probably add a known mimetype for the ​ApacheConf Lexer:

trac/mimeview/api.py

@@ -304 +304 @@
     'text/xml':                'xml',
 
     # see also TEXT_X_TYPES below
+    'text/x-apacheconf':       'apache',
     'text/x-csrc':             'c xs',
     'text/x-chdr':             'h',
     'text/x-c++src':           'cc CC cpp C c++ C++',

[Jun Omae]

That change looks good to me. We could add check of invalid wiki processors to checkwiki.py.

contrib/checkwiki.py

@@ -51 +51 @@
                 self.__marks.append((fullmatch.start(0), fullmatch.end(0)))
         return rv
 
+    def handle_code_block(self, line, startmatch=None):
+        prev_processor = getattr(self, 'code_processor', None)
+        try:
+            return self.__super.handle_code_block(line, startmatch)
+        finally:
+            processor = self.code_processor
+            if startmatch and processor and processor != prev_processor and \
+                    processor.error:
+                self.__marks.append((startmatch.start(0), startmatch.end(0)))
+
     def format(self, text, out=None):
         return self.__super.format(SourceWrapper(self, text), out)
 
@@ -160 +170 @@
     if options.download:
         download_default_pages(args, options.prefix)
 
-    env = EnvironmentStub()
+    env = EnvironmentStub(disable=['trac.mimeview.pygments.*'])
     load_components(env)
     with env.db_transaction:
         for name in names:

The same issue raises on #!pycon in TracPlugins page.

$ python contrib/checkwiki.py | grep '#!' | sed -e 's/^\([^:]*\):[0-9]*:\(.*\)$/\1:\2/' | sort | uniq -c
      3 TracCgi:{{{#!apache
      1 TracFineGrainedPermissions:{{{#!apache
      3 TracInstall:{{{#!apache
      3 TracInterfaceCustomization:{{{#!apache
     18 TracModPython:{{{#!apache
     15 TracModWSGI:{{{#!apache
      4 TracPlugins:{{{#!apache
      1 TracPlugins:{{{#!pycon
      1 TracStandalone:{{{#!apache

[Ryan J Ollos]

comment:2 change committed to 1.0-stable in [14277], merged to trunk in [14278].

The change in comment:3 seems like a good idea.

[Jun Omae]

Thanks. Committed the patch in comment:3 to 1.0-stable in [14279]. The check has limitation which works only for top level processor names.

[Ryan J Ollos]

Replying to jomae:

The same issue raises on #!pycon in TracPlugins page.

I can reproduce locally, but strangely the error is not raised on the TracPlugins page of t.e.o even though Pygments is not currently installed.

Should we add ​pycon to known mimetypes?:

trac/mimeview/api.py

@@ -338 +338 @@
     'text/x-perl':             'pl pm PL',
     'text/x-php':              'php3 php4',
     'text/x-python':           'py',
+    'text/x-python-doctest':   'pycon',
     'text/x-pyrex':            'pyx',
     'text/x-ruby':             'rb',
     'text/x-scheme':           'scm',

[Ryan J Ollos]

Looks like we also need to handle the ​genshi keyword, at least on the trunk:

trac/mimeview/api.py

@@ -301 +301 @@
     'application/x-dos-batch': 'bat batch cmd dos',
     'application/x-sh':        'sh',
     'application/x-csh':       'csh',
+    'application/x-genshi':    'genshi',
     'application/x-troff':     'nroff roff troff',
     'application/x-yaml':      'yml yaml',

[Peter Suter]

Replying to rjollos:

Replying to jomae:

The same issue raises on #!pycon in TracPlugins page.

I can reproduce locally, but strangely the error is not raised on the TracPlugins page of t.e.o even though Pygments is not currently installed.

Is that because it's in t.e.o's TracIni#mimeviewer-section:

[mimeviewer]
mime_map = application/x-genshi:genshi, application/x-genshi-text:genshitext, text/x-python-doctest:pycon, text/x-ini:ini, text/coffeescript:coffee

[Ryan J Ollos]

Thanks for the explanation. I committed the changes in comment:6 and comment:7 to 1.0-stable in [14281], merged to trunk in [14282].

[Ryan J Ollos]

I added nginx and apache to [mimeviewer] mime_map to prevent WikiProcessor errors when pygments is not installed.

Please let me know if you spot any other WikiProcessors on the site that are showing errors.

[Ryan J Ollos]

Replying to Ryan J Ollos:

I added nginx and apache to [mimeviewer] mime_map to prevent WikiProcessor errors when pygments is not installed.

Removed apache, genshi and pycon keywords from [mimeviewer] mime_map since t.e.o has been upgraded to 1.2dev and those keywords are contained in KNOWN_MIME_TYPES.

[Ryan J Ollos]

Added nginx in [14285] to [mimeviewer] mime_map to prevent WikiProcessor errors when pygments is not installed. Merged in [14286].

[Ryan J Ollos]

Replying to rjollos:

Replying to Ryan J Ollos:

I added nginx and apache to [mimeviewer] mime_map to prevent WikiProcessor errors when pygments is not installed.

Removed apache, genshi and pycon keywords from [mimeviewer] mime_map since t.e.o has been upgraded to 1.2dev and those keywords are contained in KNOWN_MIME_TYPES.

Removed nginx from mime_map since we are now running later than r14286.