Modify ↓
Opened 9 years ago
Closed 9 years ago
#12068 closed enhancement (duplicate)
Move changeset search provider to cache.py
| Reported by: | Ryan J Ollos | Owned by: | |
|---|---|---|---|
| Priority: | lowest | Milestone: | |
| Component: | version control/changeset view | Version: | |
| Severity: | normal | Keywords: | search |
| Cc: | mmitar@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
It was suggested in #9485 that the changeset search provider should be moved to trac/versioncontrol/cache.py since only cached repositories are searched.
The ISearchSource implementation currently exists in tags/trac-1.1.4/trac/versioncontrol/web_ui/changeset.py@:1114#L1112.
Attachments (1)
Change History (7)
comment:1 by , 9 years ago
| Cc: | added |
|---|
comment:2 by , 9 years ago
| Priority: | normal → lowest |
|---|
comment:3 by , 9 years ago
by , 9 years ago
| Attachment: | t12068-search-changesets.diff added |
|---|
comment:4 by , 9 years ago
I think it might be good to add search_changesets method to Repository class and ChangesetModule.get_search_results() be implemented using the method of each repository. See t12068-search-changesets.diff.
After the patch, I think we could implement it using git log --all --all-match --grep=PATTERN for git repository without cache.
Thoughts?
comment:6 by , 9 years ago
| Milestone: | next-major-releases |
|---|---|
| Resolution: | → duplicate |
| Status: | new → closed |
Turns out there was already a ticket for this, so closing as a duplicate of #10764.
Note:
See TracTickets
for help on using tickets.
Also, the Changeset search filter should only be visible when at least one cached repository exists.