First entry 8 is selected in dropdown for rows of textarea in wiki edit page by default

[Jun Omae]

When a user which its session is empty, in wiki edit page, first entry 8 is selected in dropdown for height of textarea. However, height of the textarea is 20 rows.

Pressing preview button after this, the height will be 8 rows and "8" will be stored in session. The behavior is annoying me. That is introduced in [8888#file3].

trac/wiki/web_ui.py

@@ -522 +522 @@
             page.readonly = 'readonly' in req.args
 
         author = get_reporter_id(req, 'author')
-        defaults = {'editrows': 20}
+        defaults = {'editrows': '20'}
         prefs = dict((key, req.session.get('wiki_%s' % key, defaults.get(key)))
                      for key in ('editrows', 'sidebyside'))
 

Also, the selected rows isn't stored in the user's session when the page is saved. However, if submitting changes and the changes collide against another changes, the rows will be incongruously stored in the session. See tags/trac-1.0.2/trac/wiki/web_ui.py@:155-159#L143​ and tags/trac-1.0.2/trac/wiki/web_ui.py@:543-544#L529​.

I think the rows should be stored even if submitting changes.

[Ryan J Ollos]

Replying to jomae:

When a user which its session is empty, in wiki edit page, first entry 8 is selected in dropdown for height of textarea. However, height of the textarea is 20 rows.

Pressing preview button after this, the height will be 8 rows and "8" will be stored in session. The behavior is annoying me.

Thanks, I've felt some strange behavior here before but never stopped to study it. The patch looks good to me.

[Jun Omae]

Thanks for the feedback. Fixed in [13204] and merged to trunk in [13205].

For 0.12.x users, please try ​th:TracFewFixesPlugin.

[Jun Omae]

I notice that the same issue occurs if toggling from Edit side-by-side mode on 1.0-stable. I'll fix here.

[Jun Omae]

Ouch, comment:5 is not right. I've used 1.0.2 without the patch in description. Re-closing.