#11697 closed defect (fixed)
ReportModule uses magic number -1 where None should be used — at Version 3
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.1.2 |
| Component: | report system | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
Refactored |
||
| API Changes: | |||
| Internal Changes: | |||
Description
I found this refactoring from a while back on one of my local branches. The use of -1 in ReportModule.process_request should be replaced with None in order to be more Pythonic. At least, that is the first thought I had.
Change History (3)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Milestone: | 1.0.3 → 1.1.3 |
|---|
On second thought, the change should go on the trunk since it could affect plugins implementing IRequestFilter, ITemplateStreamFilter and possibly others.
comment:3 by , 10 years ago
| Milestone: | 1.1.3 → 1.1.2 |
|---|---|
| Release Notes: | modified (diff) |
| Resolution: | → fixed |
| Status: | new → closed |
Fixed in [13048].
Note:
See TracTickets
for help on using tickets.
Proposed changes in log:rjollos.git:t11697.