NoSuchChangeset is raised if repository is empty

[Jun Omae]

In some repository types, browser page raises NoSuchChangeset if empty. Especially, when the repository is default, other registered repositories don't be shown in the browser page by the NoSuchChangeset error.

Repository type	1.0.1	0.12.5
svn	NoSuchChangeset	No error
direct-svnfs	No error	No error
git cached_repository = enabled	NoSuchChangeset	(n/a)
git cached_repository = disabled	NoSuchChangeset	(n/a)
hg	No error	No error

I think browser page shouldn't raise NoSuchChangeset even if empty.

[Ryan J Ollos]

Replying to jomae:

Especially, when the repository is default, other registered repositories don't be shown in the browser page by the NoSuchChangeset error.

I've been bothered by this as well. I didn't realize the behavior was different in Trac 0.12.x. It would be great to fix it.

[Jun Omae]

Proposed changes in jomae.git@t11584.

The issue has been introduced in [10433] which shows branch and tag labels in browser page. The feature calls repos.get_changeset() with the specified rev parameter or the youngest revision. It works well if not empty. However, it crashes due to that the youngest revision is not found if empty. [69bc9463/jomae.git] would fix it.

Git repository has another issue. SubversionRepository.get_node() with empty repository doesn't raise NoSuchChangeset and SubversionNode.get_entries() returns an empty list. But git repository raises if empty. This behavior is to show "No files" on browser page in the case. [539dd995/jomae.git] would fix it.

[Jun Omae]

I noticed that log page on an empty git repository raises a NoSuchChangeset. I'm reworking it.

[Jun Omae]

I revised jomae.git@t11584 branch. It fixes NoSuchChangeset on log page with an empty git repository.

[Jun Omae]

Committed in [12717-12720] and merged to trunk in [12721].

[Ryan J Ollos]

After [12717], it looks like we could also remove the following two lines:

tracopt/versioncontrol/svn/tests/svn_fs.py

@@ -59 +59 @@
         pool = core.svn_pool_create(None)
         dumpstream = None
         try:
-            if os.path.exists(REPOS_PATH):
-                print 'trouble ahead with db/rep-cache.db... see #8278'
             r = repos.svn_repos_create(REPOS_PATH, '', '', None, None, pool)
             if hasattr(repos, 'svn_repos_load_fs2'):
                 repos.svn_repos_load_fs2(r, dumpfile, StringIO(),

[Jun Omae]

Indeed. Committed in [12733] and merged to trunk in [12734].