Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

#11559 closed enhancement (fixed)

CommitTicketUpdater ignores [trac] ignore_auth_case

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: version control Version: 1.0-stable
Severity: normal Keywords: CommitTicketUpdater
Cc: Branch:
Release Notes:

CommitTicketUpdater applies the [trac] ignore_auth_case setting to the changeset author.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

It was discussed on the ​mailing list whether permission checks performed in CommitTicketUpdater should take into account the [trac] ignore_auth_case parameter. The authorization currently fails checking for TICKET_APPEND when the username in Subversion differs from that in Trac by casing.

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 10 years ago

Description: modified (diff)

I was too hasty in putting together the previous patch. I'll post a tested patch shortly.

comment:2 by Ryan J Ollos, 10 years ago

Proposed changes can be found in log:rjollos.git:t11559. I didn't want to mutate the changeset object by changing the author property, but maybe there is a cleaner way than applying _authname each time we may need a lower-cased author.

comment:3 by Ryan J Ollos, 10 years ago

Milestone: next-stable-1.0.x → 1.0.2
Owner: set to Ryan J Ollos
Status: new → assigned

comment:4 by Ryan J Ollos, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to 1.0-stable in [12741], merged to trunk in [12742]. I'll add a functional test case in #11440.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.