Edgewall Software

Changes between Version 21 and Version 22 of Ticket #11474


Ignore:
Timestamp:
Jul 11, 2015, 9:12:32 AM (9 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11474 – Description

    v21 v22  
    88 1. [browser:/branches/1.0-stable/trac/web/chrome.py@12468:1078,1109#L1069]
    99  * Fine-grained permission checks should be done in `format_emails` and `format_author`.
    10 
    11 This ties in closely with some other changes that were discovered while working on #10018. Those issues will be reported in other tickets.
    12 
    13 On a related note, I wonder if it would make sense to have `Chrome` implement `IPermissionRequestor` and return `EMAIL_VIEW`, rather than defining the permission in [browser:/branches/1.0-stable/trac/perm.py@12229:483-484#L473 perm.py], which is a bit out of place.
    1410
    1511For the case,
    … …  
    5450
    5551However, that's just a quick implementation, and more care is needed to fully implement the changes. It may be possible to simplify the behavior by isolating the `EMAIL_VIEW` checks to the `Chrome` class.
     52
     53This ties in closely with some other changes that were discovered while working on #10018. Those issues will be reported in other tickets.
     54
     55On a related note, I wonder if it would make sense to have `Chrome` implement `IPermissionRequestor` and return `EMAIL_VIEW`, rather than defining the permission in [browser:/branches/1.0-stable/trac/perm.py@12229:483-484#L473 perm.py], which is a bit out of place.