Add a custom field admin panel

[Ryan J Ollos]

The ​th:CustomFieldAdminPlugin seems to be a reasonable start for integrating a custom field admin panel to the Trac core. Here is an outline of the changes:

• Rework the template for minor enhancements (e.g. #11027 and #11056), improved styling and to make the markup more consistent with the other ticket admin_* templates.
• Add a CustomField class to trac.ticket.model that wraps the configuration. Later on, the storage can be changes from trac.ini to the database without changing the interface.
• Modify the CustomFieldAdminPanel class to inherit from TicketAdminPanel and refactor.
• Add functional test cases.

Proposed changes will be posted within the next few days.

[Ryan J Ollos]

Work in progress in log:rjollos.git:t11469.1, but there is still a lot of work to do. It is based on the latest, ​r13733 of ​CustomFieldAdminPlugin.

The following open ticket should probably be addressed in the course of this work:

• ​th:#7015 - Support datetime fields
• ​th:#7156 - API for defining new types of custom fields?
• ​th:#9173 - Too many updates to trac.ini
• ​th:#10284 - Support custom text field formats reference and list

​th:#11826 will be fixed implicitly by inheriting from TicketAdminPanel and ​th:#11855 was reported after fixing on the branch. However, hopefully ​th:#11855 gets committed ad it should address an issue with ​CustomFieldAdminPlugin that will be seen after [12512].

[Jun Omae]

Replying to rjollos:

• ​th:#7156 - API for defining new types of custom fields?

Previously, I've worked it in ​https://github.com/jun66j5/trac-customfieldadminplugin/commit/8532c814 by reference to FieldRefactoring. In the branch, it added ICustomFieldTypeProvider interface which allows to define new types.

The modified customfieldadminplugin is actually used with Trac 0.12 in our company.

[Peter Suter]

Replying to jomae:

Replying to rjollos:

• ​th:#7156 - API for defining new types of custom fields?

Previously, I've worked it in ​https://github.com/jun66j5/trac-customfieldadminplugin/commit/8532c814 by reference to FieldRefactoring. In the branch, it added ICustomFieldTypeProvider interface which allows to define new types.

Is this only for extending the admin panel or does this allow implementing the new ticket field types itself?

(When working with the new datetime fields I wondered if this was possible, but there seemed to be too many places in Trac that needed slightly different special support. I also found ​old discussions of a ITicketFieldTypeProvider apparently once implemented in Workflow sandbox.)

[Jun Omae]

Replying to psuter:

Replying to jomae:

Previously, I've worked it in ​https://github.com/jun66j5/trac-customfieldadminplugin/commit/8532c814 by reference to FieldRefactoring. In the branch, it added ICustomFieldTypeProvider interface which allows to define new types.

Is this only for extending the admin panel or does this allow implementing the new ticket field types itself?

The latter. The changes allow to add new field types. Of course, the new types can be selected in custom field admin panel.

(When working with the new datetime fields I wondered if this was possible, but there seemed to be too many places in Trac that needed slightly different special support. I also found ​old discussions of a ITicketFieldTypeProvider apparently once implemented in Workflow sandbox.)

Oh, thanks. I didn't notice that. I'll read the discussion later. But I cannot find the interfaces in log:sandbox/workflow@4456​. (The branch has been removed in [4457]).

[Peter Suter]

Looks like the branch was deleted once before in [3872], so from log:sandbox/workflow@3871 you can find the interface is added in [3052].

[Ryan J Ollos]

Narrowing focus for 1.1.4.

[Ryan J Ollos]

​#12217 should be investigate while preparing these changes.

[Ryan J Ollos]

Milestone renamed

[Ryan J Ollos]

#12264 closed as a duplicate.

[Ryan J Ollos]

#10811 closed as a duplicate.

[christiaan@…]

Please test in conjunction with ​th:CatagorizedFieldsPlugin

[Ryan J Ollos]

Replying to Jun Omae:

Replying to rjollos:

• ​th:#7156 - API for defining new types of custom fields?

Previously, I've worked it in ​https://github.com/jun66j5/trac-customfieldadminplugin/commit/8532c814 by reference to FieldRefactoring. In the branch, it added ICustomFieldTypeProvider interface which allows to define new types.

Created #13206.

[Ryan J Ollos]

Milestone renamed