Difficult to edit directly text field with date/time picker

[Jun Omae]

The date/time picker on Trac has some issues. It is difficult to edit directly caused by the following issue.

1. Restore immediately the value after removing end of the text field with backspace key
2. Move the cursor to end of the text field after removing hours part
3. Fill the text field with today after focusing even if it's empty

See ​https://groups.google.com/d/msg/trac-users/1Xi8cz-m1KY/7E8ZgU6WjKgJ.

[Jun Omae]

I've tried the latest of jquery-ui-addons.js, v1.4.3. But it isn't fixed.

I investigated it and noticed that timezone list must have default timezone even if the timezone is not used. The default timezone is at tags/trac-1.0.1/trac/htdocs/js/jquery-ui-i18n.js@:42#L28​.

trac/web/chrome.py

@@ -1141 +1141 @@
             'first_week_day': get_first_week_day_jquery_ui(req),
             'timepicker_separator': 'T' if is_iso8601 else ' ',
             'show_timezone': is_iso8601,
+            # default timezone must be included
             'timezone_list': get_timezone_list_jquery_ui() \
-                             if is_iso8601 else [],
+                             if is_iso8601 else ['Z'],
             'timezone_iso8601': is_iso8601,
         })
         add_script(req, 'common/js/jquery-ui-i18n.js')

The patch would fix the issues. However, even with the patch, the cursor is moved to end when invalid hours is typed.

[Jun Omae]

Committed with tests in [12370] and merged in [12371].