Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11244, comment 6


Ignore:
Timestamp:
Aug 14, 2013, 9:59:22 AM (11 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11244, comment 6

    initial v1  
    1313> The ordering of `permission_policies` can be critical. Does it matter here, or should this work in any order?
    1414
    15 `ReadonlyWikiPolicy` needs to come before `DefaultPermissionPolicy` because the latter will grant the permission and then `ReadonlyWikiPolicy` won't even be checked. If `AuthzPolicy` is enabled, `ReadonlyWikiPolicy` should come after `AuthzPolicy`, I think.
     15`ReadonlyWikiPolicy` needs to come before `DefaultPermissionPolicy` because the latter will return `True` if the user has the permission (e.g. `WIKI_MODIFY`) and then `ReadonlyWikiPolicy` won't even be checked. If `AuthzPolicy` is enabled, `ReadonlyWikiPolicy` should come after `AuthzPolicy`, I think.
    1616
    1717> Maybe instead of `return 'WIKI_ADMIN' in perm` we should only `if not 'WIKI_ADMIN' in perm: return False`, so other policies can deny permissions for other reasons.