Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11244, comment 3


Ignore:
Timestamp:
Sep 21, 2013, 5:43:43 AM (11 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11244, comment 3

    initial v1  
    11That's an interesting idea. I took a crack at implementing it in repos:rjollos.git:t11244. The branch was tested with `permission_policies = WikiPermissionPolicy, DefaultPermissionPolicy, LegacyAttachmentPolicy`.
    22
    3 I like that it localizes all of the elevated permission checks for read-only pages to a single location. Addition work is needed - adding functional tests and an environment upgrade step.
     3I like that it localizes all of the elevated permission checks for read-only pages to a single location. Additional work is needed - adding functional tests and an environment upgrade step.
    44
    55With the changes made so far, there is really no use case I can see for removing `WikiPermissionPolicy` from `permission_policies` in //trac.ini//. Removing it would result in a confusing situation in which there is a //read-only// checkbox on the form that has no effect. Therefore we should probably not add the //read-only// checkbox to the edit form unless `WikiPermissionPolicy` is active.