Edgewall Software
Modify ↓

Opened 11 years ago

Closed 11 years ago

#11187 closed defect (fixed)

Wiki syntax rendering: lists with letters are converted to numbers

Reported by: schlamar Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: wiki system Version: 1.0.1
Severity: normal Keywords:
Cc: stein.somers@… Branch:
Release Notes:

Fix wrong rendering list with letters in wiki to list with numbers in html.

API Changes:
Internal Changes:

Description

Input: 

a. 1
b. 2

s. x

Output:

  1. 1
  2. 2
  1. x

Attachments (0)

Change History (10)

comment:1 by schlamar, 11 years ago

Component: rendering → ticket system

Ah, this issue affects only ticket comments.

Same issue in this Trac instance. The following is actually s. x:

  1. x

comment:2 by Christian Boos, 11 years ago

Component: ticket system → wiki system
Milestone: → next-stable-1.0.x

Funny indeed.

comment:3 by Jun Omae, 11 years ago

It seems that the issue is introduced in r10534….

  • trac/htdocs/css/ticket.css 

    diff --git a/trac/htdocs/css/ticket.css b/trac/htdocs/css/ticket.css
index c482dee..17e181f 100644
    a b div.comment ul { list-style: disc }  
    159159div.comment ul ul, div.comment ol ul { list-style: circle }
    160160div.comment ul ul ul, div.comment ol ul ul { list-style: square }
    161161div.comment ul ol ul, div.comment ol ol ul { list-style: square }
    162 div.comment ol { list-style: decimal }
    163162
    164163/* Comment editor */
    165164#trac-comment-editor { margin-left: 2em; margin-bottom: 1em }

comment:4 by Stein Somers <stein.somers@…>, 11 years ago

Cc: stein.somers@… added

comment:5 by Jun Omae, 11 years ago

Milestone: next-stable-1.0.x → 1.0.2
Owner: set to Jun Omae
Status: new → assigned

comment:6 by Jun Omae, 11 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Applied in [11859] and merged in [11860].

comment:7 by Christian Boos, 11 years ago

Resolution: fixed
Status: closed → reopened

Forgot to comment earlier on that ticket, but if you remove that rule, an ordered list in threaded comment mode will show up with the lower-right arrow (inreply.png) as its bullet… (see for example demo-1.0:ticket:2105#comment:2, disable the CSS rule manually in the browser as that site is not running with r11859).

in reply to:  7 ; comment:8 by Jun Omae, 11 years ago

Replying to cboos:

Forgot to comment earlier on that ticket, but if you remove that rule, an ordered list in threaded comment mode will show up with the lower-right arrow (inreply.png) as its bullet… (see for example demo-1.0:ticket:2105#comment:2, disable the CSS rule manually in the browser as that site is not running with r11859).

Oh, sorry. I have not confirmed "threaded comments".

Worked again. After the following patch, works well. I've confirmed threaded comments and non-threaded comments with Firefox 22, Chrome 29 beta and IE 8.

  • trac/htdocs/css/ticket.css 

    diff --git a/trac/htdocs/css/ticket.css b/trac/htdocs/css/ticket.css
index 17e181f..7e18e20 100644
    a b  
    132132ul.children {
    133133 margin-top: 1.5em;
    134134 padding-left: 2em;
    135  list-style-image: url(../inreply.png);
    136135}
     136ul.children, ul.children ul.children { list-style-image: url(../inreply.png) }
     137ul.children ul, ul.children ol { list-style-image: none }
    137138ul.children > li.child {
    138139 padding-left: .5em;
    139140 margin-bottom: 1.5em;
    … … ul.children > li.child {  
    155156 #changelog h3, #ticketchange h3 { box-shadow: none }
    156157}
    157158
    158 div.comment ul { list-style: disc }
    159 div.comment ul ul, div.comment ol ul { list-style: circle }
    160 div.comment ul ul ul, div.comment ol ul ul { list-style: square }
    161 div.comment ul ol ul, div.comment ol ol ul { list-style: square }
    162 
    163159/* Comment editor */
    164160#trac-comment-editor { margin-left: 2em; margin-bottom: 1em }
    165161#trac-comment-editor div.trac-resizable { width: 100% }

in reply to:  8 comment:9 by Christian Boos, 11 years ago

Replying to jomae:

After the following patch, works well.

Yep, I've tested it as well, works great. Thanks!

comment:10 by Jun Omae, 11 years ago

Resolution: → fixed
Status: reopened → closed

Applied in [11861] and merged in [11862], closed again. Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.