Edgewall Software
Modify

Ticket #1115 (closed defect: worksforme)

Opened 7 years ago

Last modified 3 years ago

default_charset option not working

Reported by: trustin@… Owned by: jonas
Priority: normal Milestone:
Component: version control Version: 0.11
Severity: normal Keywords: source charset unicode verify
Cc: tiger@…, dlin@…
Release Notes:
API Changes:

Description

Source browser assumes the encoding of source codes is UTF-8. It would be nice if trac can auto-detect the actual encoding or use the config entry from trac.ini, and convert them to UTF-8 using iconv.

Attachments

Change History

comment:1 Changed 7 years ago by anonymous

  • Component changed from general to browser

comment:2 Changed 7 years ago by anonymous

  • Priority changed from normal to highest
  • Severity changed from normal to critical

comment:3 Changed 7 years ago by cmlenz

  • Keywords charset added; browse encoding removed
  • Priority changed from highest to normal
  • Resolution set to worksforme
  • Severity changed from critical to normal
  • Status changed from new to closed

TracIni has a default_charset option for this:

[trac]
default_charset = iso-8859-1

comment:4 Changed 7 years ago by twenim@…

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Default_charset option is not working

Environment

  • OS : RedHat? 9
  • Environment variable : LANG=ko_KR.eucKR
  • Trac.ini :
    [trac]
    default_charset = iso-8859-1
    

example

검색:      Navigation
twe로 로그인 로그아웃 설정 도움말 
FAQ 
접근성 
Trac에 대해 
위키 시간 순 이력 로드맵 소스 둘러보기 티켓 보기 티켓 등록 검색 
Revision Log 
root/trunk/xdocs/회의록/2005010402 요구사항과 계획수립.txt
View revision:  Revision 2 (by twe, 01/10/05 17:34:48)  최초 임포트 
 

¡Ü À¯ÁîÄÉÀ̽º
- ÀÎÅͺä´ë»óÀÚ : Áö¿¬½Ä, ÀÌÁÖ¿±, »çÀå´Ô, ±è°æÅÂ, ½Å¿ë¼ö, °­Á¤¿Ï, ±èÀÎÈ£, ½ÉÁØÇö
- ÀÎÅͺ丮Æ÷Æ®

- »ç¿ø °ü¸® : Á¶Á÷µµ, »ç¿ø, ºÎ¼­, ÀÎÁõ, ±ÇÇѼ³Á¤, ±ÙÅÂ, ÃâÅð±Ù, Á÷±Þ
- Task °ü¸® (ÇöÀçÂÊÁö, À̽´°ü¸®, ÀÏÁ¤°ü¸®, ÀüÀÚ°áÀç Æ÷ÇÔ)

comment:5 Changed 7 years ago by cmlenz

  • Summary changed from Source browser should support other encodings than UTF-8 to default_charset option not working

Shouldn't you be using a default_charset of euc-kr instead of iso-8859-1 there?

comment:6 Changed 7 years ago by twenim@…

  • Resolution set to worksforme
  • Status changed from reopened to closed

comment:7 Changed 7 years ago by tiger@…

  • Component changed from browser to changeset view
  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Version changed from 0.8 to devel

default_charset works for code browser but does not affect for changeset view. Native chars in diffs' display are jammed.

comment:8 Changed 7 years ago by cmlenz

What exact revision are you using? This looks related to #1556 and #1457, both of which should be fixed in trunk.

comment:9 Changed 7 years ago by tiger@…

  • Cc tiger@… added

I'm using [1585]. I can't upgrade to latest trunk version to check if this issue exists there as well due to #1535.

Instead of national chars there is ?????? sequences in the changest view, but the commit log message in the top of the page is ok.

comment:10 Changed 6 years ago by cboos

  • Milestone set to 0.10
  • Resolution set to fixed
  • Status changed from reopened to closed

I believe this should now work correctly in 0.10.

comment:11 Changed 3 years ago by dlin@…

  • Cc dlin@… added
  • Component changed from version control/changeset view to i18n
  • Milestone changed from 0.10 to 0.11.2
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from devel to 0.11

I use trac v0.11 + mercurial + apache

I've set the apache's httpd.conf

PythonOption? TracLocale zh_TW.utf8

And trac.ini
[trac]
default_charset = big5

It can't work, I remember it workable in 0.10, is that caused by genshi?
Now, I can display Chinese in trac's page, but can NOT display source code which is big5 coded.

comment:12 Changed 3 years ago by cboos

  • Component changed from i18n to version control
  • Keywords unicode verify added
  • Milestone changed from 0.11.2 to 0.11.3

comment:13 Changed 3 years ago by jonas

  • Resolution set to worksforme
  • Status changed from reopened to closed

I just verified that Trac correctly displays big5 encoded files with default_charset = big5.

I tested this with files both in a subversion repository and as ticket attachments.

Please reopen this if you still can reproduce this somehow.

comment:14 Changed 3 years ago by cboos

  • Milestone 0.11.3 deleted
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.