Show a hint on the Basic Settings page when pytz is not installed

[Ryan J Ollos <ryan.j.ollos@…>]

As mentioned on the ​mailing list, it might be useful to show a hint next to the Default Timezone select when pytz is not installed.

The hint could simply be Install pytz for a complete list of timezones.

[Remy Blank]

Maybe only when the user has TRAC_ADMIN? A normal user will probably not have sufficient access to install pytz.

[Ryan J Ollos <ryan.j.ollos@…>]

Oh, maybe you are thinking I was suggesting this for the preferences panel? I'm only suggesting it for the Basic Settings admin panel, which is only visible to a user with TRAC_ADMIN.

[Remy Blank]

Oh, right, my bad. Please proceed ;)

[Ryan J Ollos <ryan.j.ollos@…>]

There is a patch in ​58387c53 that I've manually tested. I'm not seeing how to write a functional test for this, but maybe someone has an idea of how I can control the import of pytz in trac.util.datefmt. I can only think of very ugly ways to accomplish this.

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

[…] I'm not seeing how to write a functional test for this, but maybe someone has an idea of how I can control the import of pytz in trac.util.datefmt. I can only think of very ugly ways to accomplish this.

On second thought, I may have been over-thinking this. I was trying to figure out a way to test within a single environment the cases where pytz is and is not present. However, it seems better to just write the test to work correctly for each case, and then to run the test cases within environments where pytz is and is not present in order to test the respective behaviors.

Functional test case added in ​86b88f40.

[Ryan J Ollos <ryan.j.ollos@…>]

With the aim of not breaking anything on my very first commit (always nice to get off to a good start!), this seemed like a good ticket to resolve. I made the string added to the template translatable, read through TracL10N and ​genshi:wiki:Documentation/i18n.html, and made sure that the string translated correctly (via modification to ES). I didn't update the catalog template since it looked like it doesn't get updated every time that a translatable string is added. The changeset is in ​da7296ce and I'll push it tomorrow if no one spots any problems.

Just noticed that I have an rjollos.git now. Thanks Jun! I'll start staging my changes there after I get all my existing branches from GitHub pushed to t.e.o.

[Ryan J Ollos <ryan.j.ollos@…>]

I didn't read carefully enough last evening. I see now that the i18n:msg attribute is only needed if the string contains markup or dynamic parameters. I will fix the changeset before committing.

[Ryan J Ollos]

Committed to 1.0-stable in [11821].

[Ryan J Ollos]

Merged to trunk in [11844].

In the future I'll make sure to do this at the time the change is committed to a branch, and will get the trunk caught up shortly on other recent changes I've pushed.

[Ryan J Ollos]

I was thinking of adding hints for Default language and Default date format as well: Install babel for extended language support, Install babel for localized date formats. Does that seem useful?

[Ryan J Ollos]

Replying to rjollos:

I was thinking of adding hints for Default language and Default date format as well: Install babel for extended language support, Install babel for localized date formats. Does that seem useful?

See #11257.

Two minor code changes for this ticket were committed in [11878:11879] while working on #11257. and merged to the trunk in [11881].