Show info message when page is renamed

[Ryan J Ollos <ryan.j.ollos@…>]

It would be comforting to show a notice message when a page is renamed. For example,

close The page TracGuide has been renamed to SuperAwesomeTracGuide.

This would also be more consistent with the other occurrences of a notice being added.

[Ryan J Ollos <ryan.j.ollos@…>]

Patch against r11693 of the trunk.

[Ryan J Ollos <ryan.j.ollos@…>]

t11080-r11693-1.patch​ is against the current trunk. I figured that since there are translatable strings being added, this can't be included in 1.0.2. Is it okay to put the add_notices within the with block? It keeps the logic simpler when adding a separate message for the redirect case.

[Remy Blank]

Looks good, but please place the add_notice() calls outside (at the end of) the transaction block. The notice would be confusing if the transaction was aborted due to an exception (it would be shown anyway).

[Christian Boos]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

[…] since there are translatable strings being added, this can't be included in 1.0.2.

Well, we usually try to enforce a string freeze some weeks before a release, but other than that, it's OK to add new texts.

[Ryan J Ollos <ryan.j.ollos@…>]

Patch against r11693 of the trunk.

[Ryan J Ollos <ryan.j.ollos@…>]

t11080-r11693-2.patch​ incorporates the suggestion from comment:2, and applies cleanly against branches/1.0-stable​.

[Ryan J Ollos <ryan.j.ollos@…>]

I've also applied the patch to ​3529c2d4, a Git branch of the latest 1.0-stable as of this writing. Let me know if that helps at all when pulling this in, or if there is anything else I can to make the process easier.

Here is the resulting message for the case that a redirect is added:

close

• The page WikiStart has been renamed to WikiStop.
• The page WikiStart has been created with a redirect to WikiStop.

[Christian Boos]

Applied in r11699, thanks!

And I changed created to recreated.