Edgewall Software
Modify

Ticket #1032 (closed enhancement: fixed)

Opened 7 years ago

Last modified 6 years ago

[patch] Recognize Subversion-style revision numbers (rNNNN) as a changeset link

Reported by: rmunn@… Owned by: cmlenz
Priority: normal Milestone: 0.9
Component: wiki system Version: 0.8
Severity: normal Keywords: wikiformatter helpwanted
Cc:
Release Notes:
API Changes:

Description (last modified by cmlenz) (diff)

Currently (as of Trac 0.8), the Wiki recognizes [N] as a changeset link, and will recognize that syntax in commit log messages. But the traditional format for writing Subversion revision numbers is rNNNN. See, for instance, http://svnbook.red-bean.com/en/1.1/ch04s04.html, where commit log messages like "Merged my-calc-branch changes r406:480 into the trunk" or "Undoing change committed in r303" are given as examples.

I propose that WikiFormatter.py should recognize not just [N] format, but also rNNNN format, as a changeset link.

Attachments

patch-recognize-subversion-style-revision-numbers-r1111.diff (1.3 KB) - added by rmunn@… 7 years ago.

Download all attachments as: .zip

Change History

comment:1 Changed 7 years ago by rmunn@…

Please note that I have not yet tested this patch. I should have a working Trac installation in a week or so; when I do, I'll test my patch and update this ticket if testing reveals any problems.

comment:2 Changed 7 years ago by cboos@…

It works, but what gets actually displayed for e.g.
r123 is still the usual [123]. Was that intended?
I see no problem with that, however, it will tell
people the "right" notation to use :)

comment:3 Changed 7 years ago by cmlenz

  • Keywords helpwanted added

comment:4 Changed 7 years ago by cmlenz

  • Milestone set to 0.9
  • Owner changed from jonas to cmlenz
  • Status changed from new to assigned

comment:5 Changed 7 years ago by cmlenz

  • Description modified (diff)

comment:6 Changed 7 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from assigned to closed

This notation has been added to the wiki formatter in [1224]. Forgot to mention this change in the log message, sorry. Only lower case 'r' prefix is matched.

comment:7 Changed 6 years ago by cboos

r2165 added support for "Merged my-calc-branch changes r406:480 into the trunk"

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cmlenz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.