Edgewall Software

Changes between Initial Version and Version 1 of Ticket #10018, comment 41


Ignore:
Timestamp:
Jul 30, 2014, 9:46:23 AM (10 years ago)
Author:
Peter Suter

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10018, comment 41

    initial v1  
    88Your analysis looks correct to me. Good catch.
    99
    10 Seems like an easy mistake to make. ([th:browser:accountmanagerplugin/0.11/acct_mgr/macros.py@12400:100,142-143#L99 another example?]) Should [browser:trunk/trac/perm.py@13045:413,430#L401 get_users_with_perm()] maybe return a copy of the cached list?
     10Seems like an easy mistake to make. ([th:browser:accountmanagerplugin/0.11/acct_mgr/macros.py@12400:100,142-143#L99 another example?]) Should [browser:trunk/trac/perm.py@13045:413,430#L401 get_users_with_permission()] maybe return a copy of the cached list?
    1111
    1212Instead of `owners = list(...)` and `owners.sort()` we could use `owners = sorted(...)`.