Ticket #7518: imports.patch

trac/attachment.py

@@ -25 +25 @@
 
 from genshi.builder import tag
 
-from trac import perm, util
 from trac.config import BoolOption, IntOption
-from trac.core import *
+from trac.core import TracError, Interface, implements, ExtensionPoint, \
+                      Component
 from trac.env import IEnvironmentSetupParticipant
-from trac.mimeview import *
-from trac.perm import PermissionError, PermissionSystem, IPermissionPolicy
-from trac.resource import *
+from trac.mimeview import Context, Mimeview
+from trac.perm import IPermissionPolicy
+from trac.resource import Resource, ResourceNotFound, IResourceManager, \
+                          get_resource_name, get_resource_url, ResourceSystem, \
+                          get_resource_summary, get_resource_shortname
 from trac.search import search_to_sql, shorten_result
-from trac.util import get_reporter_id, create_unique_file, content_disposition
+from trac.util import get_reporter_id, create_unique_file
 from trac.util.datefmt import to_timestamp, utc
-from trac.util.text import unicode_quote, unicode_unquote, pretty_size
+from trac.util.text import unicode_quote, unicode_unquote
 from trac.util.translation import _
 from trac.web import HTTPBadRequest, IRequestHandler
 from trac.web.chrome import add_link, add_stylesheet, add_ctxtnav, \

trac/env.py

@@ -24 +24 @@
 from urlparse import urlsplit
 
 from trac import db_default
-from trac.config import *
+from trac.config import Configuration, Option, PathOption, BoolOption
 from trac.core import Component, ComponentManager, implements, Interface, \
                       ExtensionPoint, TracError
 from trac.db import DatabaseManager

trac/prefs/api.py

@@ -11 +11 @@
 # individuals. For the exact contribution history, see the revision
 # history and logs, available at http://trac.edgewall.org/log/.
 
-from trac.core import *
+from trac.core import Interface
 
+__all__ = ['IPreferencePanelProvider']
 
+
 class IPreferencePanelProvider(Interface):
 
     def get_preference_panels(req):

trac/prefs/web_ui.py

@@ -14 +14 @@
 #
 # Author: Daniel Lundin <daniel@edgewall.com>
 
-from datetime import datetime
 import pkg_resources
 import re
 
@@ -25 +24 @@
 
 from genshi.builder import tag
 
-from trac.core import *
+from trac.core import Component, ExtensionPoint, implements
 from trac.prefs.api import IPreferencePanelProvider
 from trac.util.compat import sorted
 from trac.util.datefmt import all_timezones, get_timezone, localtz

trac/mimeview/rst.py

@@ -25 +25 @@
 __docformat__ = 'reStructuredText'
 
 from distutils.version import StrictVersion
-import re
 try:
     from docutils import nodes
     from docutils.core import publish_parts
@@ -35 +34 @@
 except ImportError:
     has_docutils = False
 
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.mimeview.api import IHTMLPreviewRenderer, content_to_unicode
 from trac.util.html import Element, Markup
 from trac.util.translation import _
-from trac.web.href import Href
 from trac.wiki.api import WikiSystem
 from trac.wiki.formatter import WikiProcessor, Formatter, extract_link
 

trac/mimeview/api.py

@@ -65 +65 @@
 from genshi.input import HTMLParser
 
 from trac.config import IntOption, ListOption, Option
-from trac.core import *
+from trac.core import implements, Component, TracError, ExtensionPoint, \
+    Interface
 from trac.resource import Resource
 from trac.util import reversed, sorted, Ranges
 from trac.util.text import to_utf8, to_unicode

trac/mimeview/txtl.py

@@ -18 +18 @@
 See also: http://dealmeida.net/projects/textile/
 """
 
-from trac.core import *
+from trac.core import implements, Component
 from trac.mimeview.api import IHTMLPreviewRenderer
 
 

trac/mimeview/silvercity.py

@@ -24 +24 @@
 
 from genshi.core import Markup
 
-from trac.core import *
+from trac.core import implements, Component
 from trac.config import ListOption
 from trac.mimeview.api import IHTMLPreviewRenderer, Mimeview
 from trac.util import get_pkginfo

trac/mimeview/patch.py

@@ -18 +18 @@
 
 import os.path
 
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.mimeview.api import content_to_unicode, IHTMLPreviewRenderer, \
                               Mimeview
 from trac.util.html import escape, Markup
 from trac.util.text import expandtabs
 from trac.util.translation import _
-from trac.web.chrome import Chrome, add_script, add_stylesheet
+from trac.web.chrome import add_script, add_stylesheet
 
 __all__ = ['PatchRenderer']
 

trac/mimeview/pygments.py

@@ -17 +17 @@
 from pkg_resources import resource_filename
 import re
 
-from trac.core import *
+from trac.core import implements, Component
 from trac.config import ListOption, Option
 from trac.mimeview.api import IHTMLPreviewRenderer, Mimeview
 from trac.prefs import IPreferencePanelProvider
-from trac.util import get_module_path, get_pkginfo
+from trac.util import get_pkginfo
 from trac.util.datefmt import http_date, localtz
 from trac.web import IRequestHandler
 from trac.web.chrome import add_stylesheet

trac/mimeview/enscript.py

@@ -18 +18 @@
 from genshi.core import Markup
 
 from trac.config import Option, ListOption
-from trac.core import *
+from trac.core import implements, Component
 from trac.mimeview.api import IHTMLPreviewRenderer, Mimeview
 from trac.util import NaivePopen
-from trac.util.html import escape, Deuglifier
+from trac.util.html import Deuglifier
 
 __all__ = ['EnscriptRenderer']
 

trac/mimeview/php.py

@@ -21 +21 @@
 
 from genshi.core import Markup
 
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.config import Option
 from trac.mimeview.api import IHTMLPreviewRenderer, content_to_unicode
 from trac.util import NaivePopen
 from trac.util.html import Deuglifier
+from trac.util.translation import _
 
 __all__ = ['PHPRenderer']
 

trac/ticket/admin.py

@@ -14 +14 @@
 from datetime import datetime
 
 from trac.admin import IAdminPanelProvider
-from trac.core import *
+from trac.core import Component, implements, TracError
 from trac.perm import PermissionSystem
 from trac.resource import ResourceNotFound
 from trac.ticket import model
 from trac.util.datefmt import utc, parse_date, get_date_format_hint, \
                               get_datetime_format_hint
 from trac.util.translation import _
-from trac.web.chrome import add_link, add_script
+from trac.web.chrome import add_script
 
 
 class TicketAdminPanel(Component):

trac/ticket/api.py

@@ -15 +15 @@
 # Author: Jonas Borgström <jonas@edgewall.com>
 
 import re
-from datetime import datetime
 
 from genshi.builder import tag
 
-from trac.config import *
-from trac.core import *
-from trac.perm import IPermissionRequestor, PermissionSystem, PermissionError
+from trac.config import BoolOption, OrderedExtensionsOption
+from trac.core import Interface, implements, ExtensionPoint, Component
+from trac.perm import IPermissionRequestor, PermissionSystem
 from trac.resource import IResourceManager
 from trac.util import Ranges
 from trac.util.compat import set, sorted
-from trac.util.datefmt import utc
-from trac.util.text import shorten_line, obfuscate_email_address
+from trac.util.text import shorten_line
 from trac.util.translation import _
 from trac.wiki import IWikiSyntaxProvider, WikiParser
 

trac/ticket/web_ui.py

@@ -16 +16 @@
 
 import csv
 from datetime import datetime
-import os
 import pkg_resources
 import re
 from StringIO import StringIO
-import time
 
 from genshi.core import Markup
 from genshi.builder import tag
 
 from trac.attachment import AttachmentModule
 from trac.config import BoolOption, Option, IntOption, _TRUE_VALUES
-from trac.core import *
+from trac.core import implements, TracError, Component, ExtensionPoint
 from trac.mimeview.api import Mimeview, IContentConverter, Context
 from trac.resource import Resource, get_resource_url, \
                          render_resource_link, get_resource_shortname
 from trac.search import ISearchSource, search_to_sql, shorten_result
-from trac.ticket.api import TicketSystem, ITicketManipulator, \
-                            ITicketActionController
+from trac.ticket.api import TicketSystem, ITicketManipulator
 from trac.ticket.model import Milestone, Ticket
 from trac.ticket.notification import TicketNotifyEmail
 from trac.timeline.api import ITimelineEventProvider
 from trac.util import get_reporter_id, partition
 from trac.util.compat import any
 from trac.util.datefmt import to_timestamp, utc
-from trac.util.text import CRLF, shorten_line, obfuscate_email_address
+from trac.util.text import shorten_line, obfuscate_email_address
 from trac.util.presentation import separated
 from trac.util.translation import _, tag_, N_, gettext
 from trac.versioncontrol.diff import get_diff_options, diff_blocks

trac/ticket/report.py

@@ -23 +23 @@
 from genshi.builder import tag
 
 from trac.config import IntOption
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.db import get_column_names
 from trac.mimeview import Context
 from trac.perm import IPermissionRequestor

trac/ticket/default_workflow.py

@@ -20 +20 @@
 
 from genshi.builder import tag
 
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.perm import PermissionSystem
 from trac.env import IEnvironmentSetupParticipant
 from trac.config import Configuration

trac/ticket/model.py

@@ -18 +18 @@
 #         Christopher Lenz <cmlenz@gmx.de>
 
 import re
-import sys
-import time
 from datetime import date, datetime
 
 from trac.attachment import Attachment

trac/ticket/roadmap.py

@@ -17 +17 @@
 
 from datetime import datetime
 import re
-from time import localtime, strftime, time
+from time import time
 
 from genshi.builder import tag
 
 from trac import __version__
 from trac.attachment import AttachmentModule
 from trac.config import ExtensionOption
-from trac.core import *
+from trac.core import implements, Component, Interface, TracError
 from trac.mimeview import Context
 from trac.perm import IPermissionRequestor
-from trac.resource import *
+#from trac.resource import *
+from trac.resource import Resource, IResourceManager, get_resource_url, \
+                          get_resource_name
 from trac.search import ISearchSource, search_to_sql, shorten_result
 from trac.util.compat import set, sorted
 from trac.util.datefmt import parse_date, utc, to_timestamp, to_datetime, \
                               get_date_format_hint, get_datetime_format_hint, \
                               format_date, format_datetime
-from trac.util.text import shorten_line, CRLF, to_unicode
+from trac.util.text import shorten_line, CRLF
 from trac.util.translation import _
 from trac.ticket import Milestone, Ticket, TicketSystem
-from trac.ticket.query import Query
 from trac.timeline.api import ITimelineEventProvider
 from trac.web import IRequestHandler
-from trac.web.chrome import add_link, add_stylesheet, add_warning, \
+from trac.web.chrome import add_link, add_warning, \
                             INavigationContributor
 from trac.wiki.api import IWikiSyntaxProvider
 from trac.wiki.formatter import format_to_html
@@ -537 +538 @@
     # IRequestHandler methods
 
     def match_request(self, req):
-        import re, urllib
+        import re
         match = re.match(r'/milestone(?:/(.+))?', req.path_info)
         if match:
             if match.group(1):

trac/ticket/query.py

@@ -24 +24 @@
 from genshi.builder import tag
 
 from trac.config import Option, IntOption 
-from trac.core import *
+from trac.core import implements, TracError, Component
 from trac.db import get_column_names
 from trac.mimeview.api import Mimeview, IContentConverter, Context
 from trac.resource import Resource

trac/ticket/notification.py

@@ -16 +16 @@
 # Author: Daniel Lundin <daniel@edgewall.com>
 #
 
-from trac import __version__
-from trac.core import *
-from trac.config import *
+from trac.core import Component
+from trac.config import BoolOption, Option
 from trac.notification import NotifyEmail
 from trac.util import md5
 from trac.util.datefmt import to_timestamp
-from trac.util.text import CRLF, wrap, to_unicode
+from trac.util.text import CRLF, wrap
 
 from genshi.template.text import TextTemplate
 

trac/db/sqlite_backend.py

@@ -18 +18 @@
 import re
 import weakref
 
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.db.api import IDatabaseConnector
 from trac.db.util import ConnectionWrapper
 from trac.util import get_pkginfo

trac/db/api.py

@@ -18 +18 @@
 import urllib
 
 from trac.config import Option, IntOption
-from trac.core import *
+from trac.core import Interface, ExtensionPoint, Component, TracError
 from trac.db.pool import ConnectionPool
 from trac.util.text import unicode_passwd
 from trac.util.translation import _

trac/db/mysql_backend.py

@@ -16 +16 @@
 
 import re
 
-from trac.core import *
+from trac.core import implements, Component
 from trac.db.api import IDatabaseConnector
 from trac.db.util import ConnectionWrapper
 from trac.util import get_pkginfo
@@ -197 +197 @@
 
     def cursor(self):
         return MySQLUnicodeCursor(self.cnx)
-        
- No newline at end of file

trac/db/postgres_backend.py

@@ -16 +16 @@
 
 import re
 
-from trac.core import *
+from trac.core import Component, implements
 from trac.db.api import IDatabaseConnector
 from trac.db.util import ConnectionWrapper
 from trac.util import get_pkginfo

trac/versioncontrol/api.py

@@ -23 +23 @@
     threading._get_ident = lambda: 0
 
 from trac.config import Option
-from trac.core import *
+from trac.core import implements, Component, Interface, TracError, \
+                      ExtensionPoint
 from trac.perm import PermissionError
-from trac.resource import IResourceManager, ResourceSystem, ResourceNotFound
+from trac.resource import IResourceManager, ResourceNotFound
 from trac.util.text import to_unicode
 from trac.util.translation import _
 from trac.web.api import IRequestFilter

trac/versioncontrol/svn_fs.py

@@ -40 +40 @@
 """
 
 import os.path
-import time
 import weakref
 import posixpath
 from datetime import datetime
@@ -48 +47 @@
 from genshi.builder import tag
 
 from trac.config import ListOption
-from trac.core import *
+from trac.core import implements, Component, TracError
 from trac.versioncontrol import Changeset, Node, Repository, \
                                 IRepositoryConnector, \
                                 NoSuchChangeset, NoSuchNode

trac/admin/api.py

@@ -11 +11 @@
 # individuals. For the exact contribution history, see the revision
 # history and logs, available at http://trac.edgewall.org/log/.
 
-from trac.core import *
+from trac.core import Interface
 
+__all__ = ['IAdminPanelProvider']
 
+
 class IAdminPanelProvider(Interface):
     """Extension point interface for adding panels to the web-based
     administration interface.

trac/admin/web_ui.py

@@ -26 +26 @@
 
 from trac import __version__ as TRAC_VERSION
 from trac.admin.api import IAdminPanelProvider
-from trac.core import *
+from trac.core import Component, implements, ExtensionPoint, TracError
 from trac.perm import PermissionSystem, IPermissionRequestor
 from trac.util import get_pkginfo, get_module_path
 from trac.util.compat import partial
 from trac.util.text import to_unicode
 from trac.util.translation import _
 from trac.web import HTTPNotFound, IRequestHandler
-from trac.web.chrome import add_script, add_stylesheet, add_warning, Chrome, \
-                            INavigationContributor, ITemplateProvider
+from trac.web.chrome import add_stylesheet, add_warning, ITemplateProvider, \
+                            INavigationContributor
 
 try:
     from webadmin import IAdminPageProvider

trac/admin/console.py

@@ -24 +24 @@
 import sys
 import time
 import traceback
-import urllib
 
 from trac import __version__ as VERSION
-from trac import perm, util, db_default
-from trac.core import TracError
+from trac import perm
+from trac.core import TracError, Component
 from trac.env import Environment
 from trac.perm import PermissionSystem
-from trac.ticket.model import *
+#from trac.ticket.model import *
+from trac.ticket.model import Ticket, Type, Priority, Severity, Resolution, \
+                              Milestone, Version
 from trac.util import arity, translation
 from trac.util.datefmt import parse_date, format_date, format_datetime, utc
 from trac.util.html import html

trac/perm.py

@@ -20 +20 @@
 
 from time import time
 from trac.config import ExtensionOption, OrderedExtensionsOption
-from trac.core import *
+from trac.core import Component, Interface, implements, ExtensionPoint, \
+    TracError
 from trac.resource import Resource, get_resource_name
 from trac.util.compat import set
 from trac.util.translation import _

trac/loader.py

@@ -22 +22 @@
 import os
 import sys
 
-from trac.util.compat import set
 
 __all__ = ['load_components']
 

trac/about.py

@@ -21 +21 @@
 
 from genshi.builder import tag
 
-from trac.core import *
+from trac.core import implements, Component
 from trac.perm import IPermissionRequestor
 from trac.util.translation import _
 from trac.web import IRequestHandler

trac/wiki/api.py

@@ -21 +21 @@
 except ImportError:
     import dummy_threading as threading
 import time
-import urllib
 import re
-from StringIO import StringIO
 
 from genshi.builder import tag
 
 from trac.config import BoolOption
-from trac.core import *
+from trac.core import implements, Interface, Component, ExtensionPoint
 from trac.resource import IResourceManager
-from trac.util import reversed
-from trac.util.html import html
 from trac.util.translation import _
 from trac.wiki.parser import WikiParser
 
@@ -256 +252 @@
         return page
 
     def get_wiki_syntax(self):
-        from trac.wiki.formatter import Formatter
         lower = r'(?<![A-Z0-9_])' # No Upper case when looking behind
         upper = r'(?<![a-z0-9_])' # No Lower case when looking behind
         wiki_page_name = (

trac/wiki/web_ui.py

@@ -20 +20 @@
 import pkg_resources
 import re
 
-from genshi.core import Markup
 from genshi.builder import tag
 
 from trac.attachment import AttachmentModule
-from trac.core import *
+from trac.core import implements, TracError, Component, ExtensionPoint
 from trac.mimeview.api import Mimeview, IContentConverter, Context
 from trac.perm import IPermissionRequestor
-from trac.resource import *
+#from trac.resource import *
+from trac.resource import Resource, ResourceNotFound, get_resource_url, \
+                          get_resource_name, get_resource_summary
 from trac.search import ISearchSource, search_to_sql, shorten_result
 from trac.timeline.api import ITimelineEventProvider
 from trac.util import get_reporter_id

trac/wiki/intertrac.py

@@ -18 +18 @@
 
 from genshi.builder import Element, tag
 
-from trac.core import *
+from trac.core import implements, Component
 from trac.mimeview import Context
 from trac.perm import PermissionError
 from trac.util import sorted

trac/wiki/parser.py

@@ -20 +20 @@
 
 import re
 
-from trac.core import *
+from trac.core import Component
 from trac.notification import EMAIL_LOOKALIKE_PATTERN
 
 class WikiParser(Component):

trac/wiki/model.py

@@ -16 +16 @@
 # Author: Jonas Borgström <jonas@edgewall.com>
 #         Christopher Lenz <cmlenz@gmx.de>
 
-import time
 from datetime import datetime
 
-from trac.core import *
+from trac.core import TracError
 from trac.resource import Resource
 from trac.util.datefmt import utc, to_timestamp
 from trac.util.translation import _

trac/wiki/formatter.py

@@ -20 +20 @@
 
 import re
 import os
-import urllib
 
 from StringIO import StringIO
 
@@ -30 +29 @@
 from genshi.input import HTMLParser, ParseError
 from genshi.util import plaintext
 
-from trac.core import *
-from trac.mimeview import *
+from trac.mimeview import Mimeview, Context
 from trac.resource import get_relative_url
 from trac.util.compat import set
 from trac.wiki.api import WikiSystem, parse_args

trac/wiki/macros.py

@@ -15 +15 @@
 # Author: Christopher Lenz <cmlenz@gmx.de>
 
 from datetime import datetime
-import imp
 import inspect
 import os
 import re
@@ -24 +23 @@
 from genshi.builder import Element, tag