Ticket #7065: 7065-limit-wiki-ticket-comment-size-r7439.patch

trac/ticket/web_ui.py

@@ -106 +106 @@
     max_description_size = IntOption('ticket', 'max_description_size', 262144,
         """Don't accept tickets with a too big description.
         (''since 0.11'').""")
+
+    max_comment_size = IntOption('ticket', 'max_comment_size', 262144,
+        """Don't accept tickets with a too big comment.
+        (''since 0.11'')""")
 
     timeline_newticket_formatter = Option('timeline', 'newticket_formatter',
                                           'oneliner',
@@ -928 +932 @@
                           num=self.max_description_size))
             valid = False
 
+        # Validate comment length
+        if len(comment or '') > self.max_comment_size:
+            add_warning(req, _('Ticket comment is too long (must be less '
+                               'than %(num)s characters)',
+                               num=self.max_comment_size))
+            valid = False
+
         # Validate comment numbering
         try:
             # comment index must be a number

trac/wiki/web_ui.py

@@ -24 +24 @@
 from genshi.builder import tag
 
 from trac.attachment import AttachmentModule
+from trac.config import IntOption
 from trac.core import *
 from trac.mimeview.api import Mimeview, IContentConverter, Context
 from trac.perm import IPermissionRequestor
@@ -57 +58 @@
                ITemplateProvider)
 
     page_manipulators = ExtensionPoint(IWikiPageManipulator)
+
+    max_size = IntOption('wiki', 'max_size', 262144,
+        """Maximum allowed wiki page size in bytes. (''since 0.11'')""")
 
     PAGE_TEMPLATES_PREFIX = 'PageTemplates/'
     DEFAULT_PAGE_TEMPLATE = 'DefaultPage'
@@ -173 +177 @@
 
     def _validate(self, req, page):
         valid = True
+        
+        # Validate page size
+        if len(req.args.get('text', '')) > self.max_size:
+            add_warning(req, _('The wiki page is too long (must be less '
+                               'than %(num)s characters)',
+                               num=self.max_size))
+            valid = False
+
         # Give the manipulators a pass at post-processing the page
         for manipulator in self.page_manipulators:
             for field, message in manipulator.validate_wiki_page(req, page):