Ticket #3778: node_change_upgrade-r3787.patch

trac/db_default.py

@@ -17 +17 @@
 from trac.db import Table, Column, Index
 
 # Database version identifier. Used for automatic upgrades.
-db_version = 19
+db_version = 20
 
 def __mkreports(reports):
     """Utility function used to create report data in same syntax as the
@@ -88 +88 @@
         Column('author'),
         Column('message'),
         Index(['time'])],
-    Table('node_change', key=('rev', 'path', 'change_type'))[
+    Table('node_change')[
         Column('rev'),
         Column('path'),
         Column('node_type', size=1),
         Column('change_type', size=1),
         Column('base_path'),
         Column('base_rev'),
-        Index(['rev'])],
+        Index(['rev']),
+        Index(['rev', 'path', 'change_type'])],
 
     # Ticket system
     Table('ticket', key='id')[

trac/upgrades/db20.py

@@ +1 @@
+from trac.db import Table, Column, Index, DatabaseManager
+
+def do_upgrade(env, ver, cursor):
+    """Replace the primary key constraint on the `node_change` table by an
+    index, as the key is not unique in some circumstances (#3778).
+    """
+    cursor.execute("CREATE TEMPORARY TABLE node_change_old AS "
+                   "SELECT * FROM node_change")
+    cursor.execute("DROP TABLE node_change")
+
+    table = Table('node_change')[
+        Column('rev'),
+        Column('path'),
+        Column('node_type', size=1),
+        Column('change_type', size=1),
+        Column('base_path'),
+        Column('base_rev'),
+        Index(['rev']),
+        Index(['rev', 'path', 'change_type'])]
+
+    db_connector, _ = DatabaseManager(env)._get_connector()
+    for stmt in db_connector.to_sql(table):
+        cursor.execute(stmt)
+
+    cursor.execute("INSERT INTO node_change "
+                   "(rev,path,node_type,change_type,base_path,base_rev) "
+                   "SELECT rev,path,node_type,change_type,base_path,base_rev "
+                   "FROM node_change_old")
+    cursor.execute("DROP TABLE node_change_old")