Ticket #2463: add_required_fields_inclde_new_ticket.patch

trac/ticket/api.py

@@ -213 +213 @@
         """Default resolution for resolving (closing) tickets
         (''since 0.11'').""")
 
+    required_fields = Option('ticket', 'required_fields', '',
+        """Required fields for issues
+        (''since 0.13'').""")
+
     def __init__(self):
         self.log.debug('action controllers for ticket workflow: %r' % 
                 [c.__class__.__name__ for c in self.action_controllers])

trac/ticket/default_workflow.py

@@ -74 +74 @@
         else:
             attributes['permissions'] = [a.strip() for a in
                                          attributes['permissions'].split(',')]
+        # If no required_fields are specified, then all fields are conditional
+        if 'required_fields' not in attributes:
+            attributes['required_fields'] = []
+        else:
+            attributes['required_fields'] = [
+                a.strip() for a in attributes['required_fields'].split(',')]
+
         # Normalize the oldstates
         attributes['oldstates'] = [x.strip() for x in
                                    attributes['oldstates'].split(',')]

trac/ticket/web_ui.py

@@ -1129 +1129 @@
             add_warning(req, _("Tickets must contain a summary."))
             valid = False
             
+        action = req.args.get('action', None)
+        if action == 'leave':
+            action = ticket.values['status']
+
+        required_fields = TicketSystem(self.env).required_fields.split(',')
+        required_fields = [rf.strip() for rf in required_fields]
+        if action not in  (None, 'leave', 'new'):
+            # todo - add required fields for 'new', which are the default 
+            # required fields
+            controllers = list(
+                self._get_action_controllers(req, ticket, action))
+            if controllers:
+                action_config = controllers[0].actions.get(action, {})
+                required_fields = action_config.get('required_fields', [])
+
+        if 'description' in required_fields:
+            required_fields.remove('description')
+            if not ticket['description']:
+                add_warning(req, _(
+                    'Description field is a required field',
+                    field = 'description'))
+                valid = False
+
         # Always validate for known values
         for field in ticket.fields:
+            
+            if field['name'] in required_fields and not field['value']:
+                    add_warning(req, _('"%(field)s" is a required  field',
+                                       field = field['name']))
+                    valid = False
+
             if 'options' not in field:
                 continue
             if field['name'] == 'status':