Ticket #153: privacy.diff

trac/ticket/api.py

@@ -102 +102 @@
         field = {'name': 'owner', 'label': 'Owner'}
         if self.restrict_owner:
             field['type'] = 'select'
-            users = [''] # for clearing assignment
             perm = PermissionSystem(self.env)
-            for username, name, email in self.env.get_known_users(db):
-                if perm.get_user_permissions(username).get('TICKET_MODIFY'):
-                    users.append(username)
-            field['options'] = users
+            def valid_owner(username):
+                return perm.get_user_permissions(username).get('TICKET_MODIFY')
+            field['options'] = [username for username, name, email
+                                in self.env.get_known_users(db)
+                                if valid_owner(username)]
             field['optional'] = True
         else:
             field['type'] = 'text'

trac/ticket/web_ui.py

@@ -69 +69 @@
         """Enable the display of all ticket changes in the timeline
         (''since 0.9'').""")
 
+    show_email_addresses = BoolOption('ticket', 'show_email_addresses', 'false',
+        """Show email addresses instead of usernames in RSS feeds
+        (''since 0.11'').""")
+
     # IContentConverter methods
 
     def get_supported_conversions(self):
@@ -603 +607 @@
             'ticket': ticket,
             'context': Context(self.env, req, 'ticket', ticket.id, db=db),
             'changes': changes,
+            'show_email_addresses': self.show_email_addresses
         }
 
         output = Chrome(self.env).render_template(req, 'ticket.rss', data,

trac/ticket/report.py

@@ -278 +278 @@
 
         # Get the email addresses of all known users
         email_map = {}
-        for username, name, email in self.env.get_known_users():
-            if email:
-                email_map[username] = email
+        show_email_addresses = self.config.getbool('ticket', 'show_email_addresses')
+        data['show_email_addresses'] = show_email_addresses
+        if show_email_addresses:
+            for username, name, email in self.env.get_known_users():
+                if email:
+                    email_map[username] = email
 
         # Structure the rows and cells:
         #  - group rows according to __group__ value, if defined
@@ -313 +316 @@
                     # Special casing based on column name
                     col = col.strip('_')
                     if col == 'reporter':
-                        if '@' in value:
+                        if show_email_addresses:
+                            if '@' in value:
+                                cell['author'] = value
+                            elif value in email_map:
+                                cell['author'] = email_map[value]
+                        else:
                             cell['author'] = value
-                        elif value in email_map:
-                            cell['author'] = email_map[value]
                     elif col == 'resource':
                         resource = value
                     cell_group.append(cell)

trac/ticket/query.py

@@ -684 +684 @@
         query.verbose = True
         db = self.env.get_db_cnx()
         results = query.execute(req, db)
-        for result in results:
-            if result['reporter'].find('@') == -1:
-                result['reporter'] = ''
+        show_email_addresses = self.config.getbool('ticket', 'show_email_addresses')
+        if show_email_addresses:
+            for result in results:
+                if result['reporter'].find('@') == -1:
+                    result['reporter'] = ''
         query_href = req.abs_href.query(group=query.group,
                                         groupdesc=query.groupdesc and 1 or None,
                                         verbose=query.verbose and 1 or None,
@@ -695 +697 @@
         data = {
             'context': Context(self.env, req),
             'results': results,
+            'show_email_addresses': show_email_addresses,
             'query_href': query_href
             }
         output = Chrome(self.env).render_template(req, 'query.rss', data,

trac/versioncontrol/web_ui/log.py

@@ -179 +179 @@
         changes = get_changes(repos, revs)
         extra_changes = {}
         email_map = {}
+        show_email_addresses = self.config.getbool('ticket',
+                                                   'show_email_addresses')
         if format == 'rss':
             # Get the email addresses of all known users
-            email_map = {}
-            for username,name,email in self.env.get_known_users():
-                if email:
-                    email_map[username] = email
+            if show_email_addresses:
+                for username,name,email in self.env.get_known_users():
+                    if email:
+                        email_map[username] = email
         elif format == 'changelog':
             for rev in revs:
                 changeset = changes[rev]
@@ -207 +209 @@
             'path_links': path_links,
             'items': info, 'changes': changes,
             'email_map': email_map, 'extra_changes': extra_changes,
+            'show_email_addresses': show_email_addresses,
             'wiki_format_messages':
             self.config['changeset'].getbool('wiki_format_messages')
             }

trac/timeline/web_ui.py

@@ -138 +138 @@
 
         if format == 'rss':
             # Get the email addresses of all known users
-            email_map = {}
-            for username, name, email in self.env.get_known_users():
-                if email:
-                    email_map[username] = email
-            data['email_map'] = email_map
+            show_email_addresses = self.config.getbool('ticket', 'show_email_addresses')
+            if show_email_addresses:
+                email_map = {}
+                for username, name, email in self.env.get_known_users():
+                    if email:
+                        email_map[username] = email
+                data['email_map'] = email_map
+            data['show_email_addresses'] = show_email_addresses
             return 'timeline.rss', data, 'application/rss+xml'
 
         add_stylesheet(req, 'common/css/timeline.css')

templates/report.rss

@@ -17 +17 @@
         <py:with vars="col = cell.header.col.strip('_')">
           <py:choose>
             <py:when test="col == 'reporter'">
-              <author py:if="cell.author">$cell.author</author>
+              <author py:if="cell.author and show_email_addresses">$cell.author</author>
+              <dc:creator py:if="cell.author and not show_email_addresses">$cell.author</cd:creator>
             </py:when>
             <py:when test="col in ('time', 'changetime', 'created', 'modified')">
               <!-- FIXME: we end up with multiple pubDate -->

templates/revisionlog.rss

@@ -13 +13 @@
     </image>
 
     <item py:for="item in items" py:with="change = changes[item.rev]; item_context = context('changeset', change.rev, abs_urls=True)">
-      <author py:if="change.author" py:with="a = change.author">${a and '@' in a and a or email_map.get(a)}</author>
+      <author py:if="change.author and show_email_addresses" py:with="a = change.author">${a and '@' in a and a or email_map.get(a)}</author>
+      <dc:creator py:if="change.author and not show_email_addresses">${change.author}</dc:creator>
       <pubDate>${http_date(change.date)}</pubDate>
       <title>Revision $item.rev: ${shorten_line(change.message)}</title>
       <link>${abs_href.changeset(rev, path)}</link>

templates/timeline.rss

@@ -14 +14 @@
 
     <item py:for="event in events">
       <title>${plaintext(event.title, keeplinebreaks=False)}</title>
-      <py:with vars="author=event.author; author = author and '@' in author and author or email_map.get(author)">
+      <py:if test="show_email_addresses" py:with vars="author=event.author; author = author and '@' in author and author or email_map.get(author)">
         <author py:if="author">$author</author>
-      </py:with>
+      </py:if>
+      <dc:creator py:if="event.author and not show_email_addresses">${event.author}</dc:creator>
       <pubDate>${http_date(event.date)}</pubDate>
       <link>${event.abs_href}</link>
       <guid isPermaLink="false">${event.abs_href}/${event.dateuid()}</guid>

templates/ticket.rss

@@ -13 +13 @@
     <generator>Trac $trac.version</generator>
 
     <item py:for="change in changes">
-      <author py:if="change.author">$change.author</author>
+      <author py:if="change.author and show_email_addresses">$change.author</author>
+      <dc:creator py:if="change.author and not show_email_addresses">$change.author</dc:creator>
       <pubDate>${http_date(change.date)}</pubDate>
       <title>$change.title</title>
       <link>${abs_href.ticket(ticket.id)}<py:if test="change.cnum">#comment:$change.cnum</py:if></link>

templates/query.rss

@@ -16 +16 @@
       <guid isPermaLink="false">$href</guid>
       <title>#$result.id: $result.summary</title>
       <pubDate py:if="result.time">${http_date(result.time)}</pubDate>
-      <author py:if="result.reporter">$result.reporter</author>
+      <author py:if="result.reporter and show_email_addresses">$result.reporter</author>
+      <dc:creator py:if="result.reporter and not show_email_addresses">$result.reporter</dc:creator>
       <description>${unicode(context('ticket', result.id, abs_urls=True).wiki_to_html(result.description))}</description>
       <category>Results</category>
       <comments>$href#changelog</comments>